All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/424: add check for crc and finobt
Date: Mon, 7 Aug 2017 08:55:19 +0800	[thread overview]
Message-ID: <5987BA77.4090909@cn.fujitsu.com> (raw)
In-Reply-To: <f6dd5a90-4179-d4df-cf33-5a62b7c1aa26@sandeen.net>

On 2017/08/04 22:37, Eric Sandeen wrote:
> On 8/4/17 2:20 AM, Xiao Yang wrote:
>> Hi Eric,
>>
>> When finobt is disabled, xfs_db gets double crc errors on upstream xfsporgs-dev.
>> as below(e.g. block size is 4096):
>> ...
>> xfs_db -c "daddr 16" -c "type finobt" /dev/sda11
>> Metadata corruption detected at xfs_inobt block 0x10/0x1000
>> Metadata corruption detected at xfs_inobt block 0x10/0x1000
>>
>> Is this expected behavor?  Because xfs_db gets one crc error on v4.5 xfsprogs-dev.
>> as below(e.g. block size is 4096):
>> ...
>> xfs_db -c "daddr 16" -c "type finobt" /dev/sda11
>> Metadata CRC error detected at xfs_inobt block 0x10/0x200
> So, errors is expected because you finobt is disabled, and you are asking
> it to print a not-finobt block as a finobt.
>
> I think the double printing is because upstream the code actually sets
> the cursor twice after the commit which tried to fix the type-setting,
> it's on my list to fix.
Hi Eric,

Thanks for your detailed explanation, and i got it.
Could you help me review the v2 patch.  Thanks a lot!

Thanks,
Xiao Yang
> Thanks,
> -Eric
>
>> Thanks,
>> Xiao Yang.
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>




      reply	other threads:[~2017-08-07  0:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 12:05 [PATCH] xfs/424: add check for crc and finobt Xiao Yang
2017-08-03 14:57 ` Eric Sandeen
2017-08-04  6:43   ` Xiao Yang
2017-08-04  7:08   ` [PATCH v2] xfs/424: add check for finobt && update comments Xiao Yang
2017-08-16  1:54     ` Xiao Yang
2017-08-16  7:59       ` Eryu Guan
2017-08-04  7:20   ` [PATCH] xfs/424: add check for crc and finobt Xiao Yang
2017-08-04 14:37     ` Eric Sandeen
2017-08-07  0:55       ` Xiao Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5987BA77.4090909@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=fstests@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.