Re: [PATCH 29/34] brcmfmac: stabilise the value of ->sbwad in use for some xfer routines.

[Arend van Spriel <arend.vanspriel@broadcom.com>]

So now I jump to this patch
On 7/26/2017 10:25 PM, Ian Molton wrote:
> The IO functions operate within the Chipcommon IO window. Explicitly
> set this, rather than relying on the last initialisation IO access to
> leave it set to the right value by chance.

> Signed-off-by: Ian Molton <ian@mnementh.co.uk>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 8 ++++----
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c   | 5 +++++
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h   | 1 +
>   3 files changed, 10 insertions(+), 4 deletions(-)
>

[...]

> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h
> index fb4f24dfc99d..1ab95011adb0 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h
> @@ -178,6 +178,7 @@ struct brcmf_sdio_dev {
>   	struct sdio_func *func[SDIO_MAX_FUNCS];
>   	u8 num_funcs;			/* Supported funcs on client */
>   	u32 sbwad;			/* Save backplane window address */
> +	struct brcmf_core *cc_core;	/* chipcommon core info struct */

We actually just need the chipcommon base address so why not have that 
here, ie.:
+	u32 cc_base;

Another option is to simple use SI_ENUM_BASE as the chipcommon base 
address will always be 0x18000000 for the SDIO chips.

>   	struct brcmf_sdio *bus;
>   	struct device *dev;
>   	struct brcmf_bus *bus_if;
>