From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Wright Feng <wright.feng@cypress.com>,
franky.lin@broadcom.com, hante.meuleman@broadcom.com,
kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH v2 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled
Date: Mon, 7 Aug 2017 14:33:34 +0200 [thread overview]
Message-ID: <59885E1E.5020602@broadcom.com> (raw)
In-Reply-To: <1501753079-1758-3-git-send-email-wright.feng@cypress.com>
On 8/3/2017 11:37 AM, Wright Feng wrote:
> brcmfmac: fix wrong num_different_channels when mchan feature enabled
>
> When the device/firmware supports multi-channel, it can have P2P
> connection and regular connection with AP simultaneous. In this case,
> the num_different_channels in wiphy info was not correct when firmware
> supports multi-channel (The iw wiphy# info showed "#channels <= 1" in
> interface combinations). It caused association failed and error message
> "CTRL-EVENT-FREQ-CONFLICT error" in wpa_supplicant when P2P GO interface
> was running at the same time.
> The root cause is that the num_different_channels was always overridden
> to 1 in brcmf_setup_ifmodes even multi-channel was enabled.
> We correct the logic by moving num_different_channels setting forward.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Wright Feng <wright.feng@cypress.com>
> ---
> v2: Describe the motivation and reason for this patch in commit message
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
next prev parent reply other threads:[~2017-08-07 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 9:37 [PATCH v2 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode Wright Feng
2017-08-03 9:37 ` [PATCH v2 2/3] brcmfmac: Add support for CYW4373 SDIO/USB chipset Wright Feng
2017-08-07 12:27 ` Arend van Spriel
2017-08-08 6:53 ` Chi-Hsien Lin
2017-08-08 9:36 ` Arend van Spriel
2017-08-03 9:37 ` [PATCH v2 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled Wright Feng
2017-08-03 10:05 ` Kalle Valo
2017-08-07 12:33 ` Arend van Spriel [this message]
2017-08-03 10:04 ` [PATCH v2 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode Kalle Valo
2017-08-07 12:24 ` Arend van Spriel
2017-08-08 11:51 ` [v2, " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59885E1E.5020602@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.