From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader Date: Thu, 10 Aug 2017 10:44:13 +0200 Message-ID: <598C1CDD.3090604@iogearbox.net> References: <8ddcce8a9564e9c4a265db790002d6cd5ba8f353.1502316870.git.daniel@iogearbox.net> <20170809173512.2db1eb40@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from www62.your-server.de ([213.133.104.62]:34208 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbdHJIoR (ORCPT ); Thu, 10 Aug 2017 04:44:17 -0400 In-Reply-To: <20170809173512.2db1eb40@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On 08/10/2017 02:35 AM, Stephen Hemminger wrote: > On Thu, 10 Aug 2017 00:15:41 +0200 > Daniel Borkmann wrote: > >> Commit 69fed534a533 ("change how Config is used in Makefile's") moved >> HAVE_MNL specific CFLAGS/LDLIBS for building with libmnl out of the >> top level Makefile into sub-Makefiles. However, it also removed the >> HAVE_ELF specific CFLAGS/LDLIBS entirely, which breaks the BPF object >> loader for tc and ip with "No ELF library support compiled in." despite >> having libelf detected in configure script. Fix it similarly as in >> 69fed534a533 for HAVE_ELF. >> >> Fixes: 69fed534a533 ("change how Config is used in Makefile's") >> Reported-by: Jeffrey Panneman >> Signed-off-by: Daniel Borkmann > > Thanks, but I am thinking maybe a better solution long term would be to > move all the package specific stuff into the generated Config file. > > That way only the generation shell script would have to change. > > Also, all the flags should probably be using pkg-config to get the values. Sure, sounds all good, for the time being, I would like to have that breakage undone though, so users can work with loading BPF programs again on -master. Thanks, Daniel