From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v4 3/3] drm/tegra: output: rgb: Support LVDS encoder bridge Date: Fri, 17 Apr 2020 23:11:06 +0300 Message-ID: <598c81ef-ba22-a832-0822-e08023f3dff6@gmail.com> References: <20200417175238.27154-1-digetx@gmail.com> <20200417175238.27154-4-digetx@gmail.com> <20200417192453.GH5861@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200417192453.GH5861-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laurent Pinchart , Thierry Reding Cc: Sam Ravnborg , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 17.04.2020 22:24, Laurent Pinchart пишет: ... > As I tried to explain before, if you wrap the panel in a bridge with > drm_panel_bridge_add() (or the devm_ variant), you will always have a > bridge associated with the output, and will be able to remove your > custom connector implementation. I thus recommend converting to > drm_panel_bridge_add() either as part of this patch series, or just > after it, to get full benefits. > > With the assumption that this will be handled, > > Reviewed-by: Laurent Pinchart Thanks you very much! Yes, I got yours point about wrapping panel into the bridge. But I don't think that it's worth the effort right now because each Tegra output has it's own implantation of the connector and it should be cleaner not to touch that code. Secondly, I don't have hardware to test all available panel output types on Tegra and the benefits of messing with all that code are a bit dim to me. I can make a patch to wrap the RGB panel into a bridge, but this should make code a bit inconsistent in regards to not having a common code path for the "legacy" nvidia,panel. So perhaps it's better to leave it all as-is for now. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 891A5C352BE for ; Sat, 18 Apr 2020 09:27:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CA2F21D82 for ; Sat, 18 Apr 2020 09:27:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S/zofisQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CA2F21D82 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA82C6EC7D; Sat, 18 Apr 2020 09:26:41 +0000 (UTC) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFB8E6E418 for ; Fri, 17 Apr 2020 20:11:09 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id q19so3316717ljp.9 for ; Fri, 17 Apr 2020 13:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RVG2bKmbZ4y9wY5cq2XdNLer07BD29fUHuKQ45NDSP0=; b=S/zofisQw2cmUFHpL7bYDOmobITWYxKGamznmFa0uubA0LcW/U6BVDwgaVzg9yrt6y y3nUTBHDb0qYn8Gk9DxPea1JKpgsQ9vU8j1Owx8MFLSpjhAA2JO0GNZw1JmkTlB+vcN+ GhL+sdBO02q4u1r8kOoFPG6PM0BLNG0PK2gONOe92zN3Y8MZKw2CEz/GHSmoYWEXX1Tv H2rcyV4Sf6QKx+P8cqJfeVNfc6RPL/J8Jo1uazsuchCAwWyJyXnycANw2+Kv11BjaobM Vt1HnIkRz0s/+8YV/BXigazViRgOHwbVmCqb1oDckvEmi3vMtdiGYDRlvYDdMOo04AB9 LPHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RVG2bKmbZ4y9wY5cq2XdNLer07BD29fUHuKQ45NDSP0=; b=o3hKV1ZKVteGROX7MMGFj9HSM92BImqpsnq8PKKnGDZRk0oQPQVgHWyHKZuumVXILx SXgkRhfmkmYiD6lvcYSKQ7Wa9RLH9iuLXZpOAfJfP2olFIzCSLPzqYQopUzfWFmePvQg caEqSr4yJ5DtrhTlYhjh5q7m2HkEOi5yvpLFo8K3odfxcwIE9XODJ6UG4IqA7w++UZhN rnUUUeuUS7TnceauqqiY7qKFOKUPYA73RJlEtpN6WTZNV1pCx9T6pVF3h/FV0+XP1Nr9 eq06MJbDuYEsK8QTsn5GCzAP23xJs9i7z31GIT44YG8IapTwp1SfV9dkpgjSsHOsoMU0 DNyQ== X-Gm-Message-State: AGi0PuayUFJ4DJmNB99hOEmj0UtxdCwl6YY3aTqs2xyFMl67DqLvb/IE OjYdbzaUA44DmboXzShfFog= X-Google-Smtp-Source: APiQypL4LNbI4XRYGODAnuFJGu0VoHlcf0AIln/JkBVq4xUbETkYhCEa4zCxa6ssSicKvX1V1GpZLw== X-Received: by 2002:a05:651c:39b:: with SMTP id e27mr3323167ljp.45.1587154268305; Fri, 17 Apr 2020 13:11:08 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id z15sm15881502ljk.99.2020.04.17.13.11.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2020 13:11:07 -0700 (PDT) Subject: Re: [PATCH v4 3/3] drm/tegra: output: rgb: Support LVDS encoder bridge To: Laurent Pinchart , Thierry Reding References: <20200417175238.27154-1-digetx@gmail.com> <20200417175238.27154-4-digetx@gmail.com> <20200417192453.GH5861@pendragon.ideasonboard.com> From: Dmitry Osipenko Message-ID: <598c81ef-ba22-a832-0822-e08023f3dff6@gmail.com> Date: Fri, 17 Apr 2020 23:11:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200417192453.GH5861@pendragon.ideasonboard.com> Content-Language: en-US X-Mailman-Approved-At: Sat, 18 Apr 2020 09:26:15 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Sam Ravnborg , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MTcuMDQuMjAyMCAyMjoyNCwgTGF1cmVudCBQaW5jaGFydCDQv9C40YjQtdGCOgouLi4KPiBBcyBJ IHRyaWVkIHRvIGV4cGxhaW4gYmVmb3JlLCBpZiB5b3Ugd3JhcCB0aGUgcGFuZWwgaW4gYSBicmlk Z2Ugd2l0aAo+IGRybV9wYW5lbF9icmlkZ2VfYWRkKCkgKG9yIHRoZSBkZXZtXyB2YXJpYW50KSwg eW91IHdpbGwgYWx3YXlzIGhhdmUgYQo+IGJyaWRnZSBhc3NvY2lhdGVkIHdpdGggdGhlIG91dHB1 dCwgYW5kIHdpbGwgYmUgYWJsZSB0byByZW1vdmUgeW91cgo+IGN1c3RvbSBjb25uZWN0b3IgaW1w bGVtZW50YXRpb24uIEkgdGh1cyByZWNvbW1lbmQgY29udmVydGluZyB0bwo+IGRybV9wYW5lbF9i cmlkZ2VfYWRkKCkgZWl0aGVyIGFzIHBhcnQgb2YgdGhpcyBwYXRjaCBzZXJpZXMsIG9yIGp1c3QK PiBhZnRlciBpdCwgdG8gZ2V0IGZ1bGwgYmVuZWZpdHMuCj4gCj4gV2l0aCB0aGUgYXNzdW1wdGlv biB0aGF0IHRoaXMgd2lsbCBiZSBoYW5kbGVkLAo+IAo+IFJldmlld2VkLWJ5OiBMYXVyZW50IFBp bmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+CgpUaGFua3MgeW91IHZl cnkgbXVjaCEKClllcywgSSBnb3QgeW91cnMgcG9pbnQgYWJvdXQgd3JhcHBpbmcgcGFuZWwgaW50 byB0aGUgYnJpZGdlLiBCdXQgSSBkb24ndAp0aGluayB0aGF0IGl0J3Mgd29ydGggdGhlIGVmZm9y dCByaWdodCBub3cgYmVjYXVzZSBlYWNoIFRlZ3JhIG91dHB1dCBoYXMKaXQncyBvd24gaW1wbGFu dGF0aW9uIG9mIHRoZSBjb25uZWN0b3IgYW5kIGl0IHNob3VsZCBiZSBjbGVhbmVyIG5vdCB0bwp0 b3VjaCB0aGF0IGNvZGUuCgpTZWNvbmRseSwgSSBkb24ndCBoYXZlIGhhcmR3YXJlIHRvIHRlc3Qg YWxsIGF2YWlsYWJsZSBwYW5lbCBvdXRwdXQgdHlwZXMKb24gVGVncmEgYW5kIHRoZSBiZW5lZml0 cyBvZiBtZXNzaW5nIHdpdGggYWxsIHRoYXQgY29kZSBhcmUgYSBiaXQgZGltIHRvIG1lLgoKSSBj YW4gbWFrZSBhIHBhdGNoIHRvIHdyYXAgdGhlIFJHQiBwYW5lbCBpbnRvIGEgYnJpZGdlLCBidXQg dGhpcyBzaG91bGQKbWFrZSBjb2RlIGEgYml0IGluY29uc2lzdGVudCBpbiByZWdhcmRzIHRvIG5v dCBoYXZpbmcgYSBjb21tb24gY29kZSBwYXRoCmZvciB0aGUgImxlZ2FjeSIgbnZpZGlhLHBhbmVs LiBTbyBwZXJoYXBzIGl0J3MgYmV0dGVyIHRvIGxlYXZlIGl0IGFsbAphcy1pcyBmb3Igbm93Lgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK