From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD92ACF6A88 for ; Thu, 8 Jan 2026 09:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5nTYfSaDPv2GdlELTogMY93wplFSokquqpOtJ7cePW8=; b=HWuHZg0TKqpPxrKAAvK/uvTEwe uC3Oy59FnBwKV4vpAzY78JaCqvRhsyRIxDDZjcr0aVgI6jk9kup6pQsZ/KB+GUbdm0PyVA5bda0dm T2BpuoJ1Vu9P3tsbMqUPFy/Ekoi5avaXsOR0/RbtKP9Mq+QMIoCk0nqNHdQlj5RZqC3Q8mKOQekBv 7BaLBsp3BsbxRR1ep2ZF/zOPCKnP37uzTKx3ZHpkiDw5XeFuNfNqxCHT4eaZhWLoefJEFpDE3nLux 1dwYj8XrlTz2gjHaEWIiSrEbZczPTeuBqXBYGTXnuzKomLokwSHQLTYyfapAiyk+mvxwflg7asrT8 xhYlMwvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdm6q-0000000GPNr-3MLi; Thu, 08 Jan 2026 09:15:12 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdm6n-0000000GPMu-1ZNe; Thu, 08 Jan 2026 09:15:10 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1767863695; cv=none; d=zohomail.com; s=zohoarc; b=MmE5DKfbNllkayfuVfwm9GThSMFT+PX+Q2qcU+TqNiyd2ZutQKHKl2xQoLqUG3zsymi4xcpv2W0Cu9tMDT5XksV3frCCiyx15Nl4+t2Hkxfs5hbWrkeNSx7VctY6ioYBvzrNSkdw0NzytZvIYUK3mrk4XkTPnZ2epVMByddAHis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767863695; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5nTYfSaDPv2GdlELTogMY93wplFSokquqpOtJ7cePW8=; b=F3KXU6Fwpvtrnw4tK2M8uHd68QIlsZU0jzBBulY/5zbSLW8Qrf28FYA0wd2yxBcYgoOaMEeK18uCW7KdWet9I74deKSEifIWq+EUU30svBPjFGIkJVBbfw2DNZE/6NGA16Sp0jSGt9YeaJCJeBmx8TtXclw63wW0XBnRRcP+srY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1767863695; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=5nTYfSaDPv2GdlELTogMY93wplFSokquqpOtJ7cePW8=; b=kTicqGgqsOzHMkeRBWfRNWGcx2mI153gK3zN0TKiLHNcsKpEIms6Z+TsAIQUolqD ebLrshz40+ShAYSAlksHuN9vSpcazstbafyIfkzQAxFs9HaETySG1jl0PzLvVIvWvRP btNeqbhgsP0TcoF6ytmZY/IIEnltagUCO5ehZxLs= Received: by mx.zohomail.com with SMTPS id 1767863693938487.4499614851069; Thu, 8 Jan 2026 01:14:53 -0800 (PST) From: Nicolas Frattaroli To: "chu.stanley@gmail.com" , "robh@kernel.org" , Chunfeng Yun =?UTF-8?B?KOS6keaYpeWzsCk=?= , "kishon@kernel.org" , "James.Bottomley@HansenPartnership.com" , "bvanassche@acm.org" , AngeloGioacchino Del Regno , "neil.armstrong@linaro.org" , "conor+dt@kernel.org" , Chaotian Jing =?UTF-8?B?KOS6leacneWkqSk=?= , "lgirdwood@gmail.com" , "vkoul@kernel.org" , "krzk+dt@kernel.org" , "p.zabel@pengutronix.de" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "avri.altman@wdc.com" , "martin.petersen@oracle.com" , "broonie@kernel.org" , Peter Wang =?UTF-8?B?KOeOi+S/oeWPiyk=?= Cc: "linux-scsi@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Louis-Alexis Eyraud , "kernel@collabora.com" Subject: Re: [PATCH v4 11/25] scsi: ufs: mediatek: Rework probe function Date: Thu, 08 Jan 2026 10:14:44 +0100 Message-ID: <5992593.DvuYhMxLoT@workhorse> In-Reply-To: <213d3077835fc86d15579c0a0a91f64fd84b1059.camel@mediatek.com> References: <20251218-mt8196-ufs-v4-0-ddec7a369dd2@collabora.com> <20251218-mt8196-ufs-v4-11-ddec7a369dd2@collabora.com> <213d3077835fc86d15579c0a0a91f64fd84b1059.camel@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260108_011509_472082_A60DF8FB X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday, 6 January 2026 14:23:58 Central European Standard Time Peter Wa= ng (=E7=8E=8B=E4=BF=A1=E5=8F=8B) wrote: > On Thu, 2025-12-18 at 13:55 +0100, Nicolas Frattaroli wrote: > >=20 > > Remove the ti,syscon-reset cruft. > >=20 >=20 > Hi Nicolas, >=20 > Why do we need to remove the reset node? If an error occurs and the > host=20 > does not perform a reset, it could lead to error recovery failure. Because it's not described by the binding, and appears to be a downstream hack to work around not having the reset controller properly described and referred to with a `resets` property. Even if you were to use `ti,syscon-reset` to describe a reset controller, the UFS controller driver should not be searching for this compatible. It should access the reset through the reset API. The common reset code can then take care of probe ordering without every driver reinventing it. >=20 > Thanks. > Peter >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89601CF6A88 for ; Thu, 8 Jan 2026 09:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lHtrNmo5Lm9TQ15fz9AQAwt/sAJJ/p4fNtqPEyNqBCI=; b=CdDJTp38tIcaLf gwTIWwC8sXlj3M6gZrsqt/DreMmbEoG/hU7LPIvmqwBq0xGWkz2D3bnMZhhnSnHbImP732agGKAs/ ZH2C/mGZzaoZjXaGBYKiTtvkfzArOfZbo+C22yQIEdC/Ez8i20usRPOH05+vkd+2b6RC0AjodOt0L 274FF0LCN/u2GwsarV2lzOYJJc37ssyUDQLJtnsGxfKvLUqJOz1dnwh/rQqlH6rsKLVPtV6E1MI2P VNNJJL7ubCQdj01g2w/mcmtHmkTmAKjkkFAZ9Ibn2gwzSzzOMfBOkoqqgXrBKwdsWKC24LmXrOFfK zUsFF5gA6y1696jZ9kng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdm6r-0000000GPNx-0P8r; Thu, 08 Jan 2026 09:15:13 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdm6n-0000000GPMu-1ZNe; Thu, 08 Jan 2026 09:15:10 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1767863695; cv=none; d=zohomail.com; s=zohoarc; b=MmE5DKfbNllkayfuVfwm9GThSMFT+PX+Q2qcU+TqNiyd2ZutQKHKl2xQoLqUG3zsymi4xcpv2W0Cu9tMDT5XksV3frCCiyx15Nl4+t2Hkxfs5hbWrkeNSx7VctY6ioYBvzrNSkdw0NzytZvIYUK3mrk4XkTPnZ2epVMByddAHis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767863695; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5nTYfSaDPv2GdlELTogMY93wplFSokquqpOtJ7cePW8=; b=F3KXU6Fwpvtrnw4tK2M8uHd68QIlsZU0jzBBulY/5zbSLW8Qrf28FYA0wd2yxBcYgoOaMEeK18uCW7KdWet9I74deKSEifIWq+EUU30svBPjFGIkJVBbfw2DNZE/6NGA16Sp0jSGt9YeaJCJeBmx8TtXclw63wW0XBnRRcP+srY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1767863695; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=5nTYfSaDPv2GdlELTogMY93wplFSokquqpOtJ7cePW8=; b=kTicqGgqsOzHMkeRBWfRNWGcx2mI153gK3zN0TKiLHNcsKpEIms6Z+TsAIQUolqD ebLrshz40+ShAYSAlksHuN9vSpcazstbafyIfkzQAxFs9HaETySG1jl0PzLvVIvWvRP btNeqbhgsP0TcoF6ytmZY/IIEnltagUCO5ehZxLs= Received: by mx.zohomail.com with SMTPS id 1767863693938487.4499614851069; Thu, 8 Jan 2026 01:14:53 -0800 (PST) From: Nicolas Frattaroli To: "chu.stanley@gmail.com" , "robh@kernel.org" , Chunfeng Yun =?UTF-8?B?KOS6keaYpeWzsCk=?= , "kishon@kernel.org" , "James.Bottomley@HansenPartnership.com" , "bvanassche@acm.org" , AngeloGioacchino Del Regno , "neil.armstrong@linaro.org" , "conor+dt@kernel.org" , Chaotian Jing =?UTF-8?B?KOS6leacneWkqSk=?= , "lgirdwood@gmail.com" , "vkoul@kernel.org" , "krzk+dt@kernel.org" , "p.zabel@pengutronix.de" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "avri.altman@wdc.com" , "martin.petersen@oracle.com" , "broonie@kernel.org" , Peter Wang =?UTF-8?B?KOeOi+S/oeWPiyk=?= Cc: "linux-scsi@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Louis-Alexis Eyraud , "kernel@collabora.com" Subject: Re: [PATCH v4 11/25] scsi: ufs: mediatek: Rework probe function Date: Thu, 08 Jan 2026 10:14:44 +0100 Message-ID: <5992593.DvuYhMxLoT@workhorse> In-Reply-To: <213d3077835fc86d15579c0a0a91f64fd84b1059.camel@mediatek.com> References: <20251218-mt8196-ufs-v4-0-ddec7a369dd2@collabora.com> <20251218-mt8196-ufs-v4-11-ddec7a369dd2@collabora.com> <213d3077835fc86d15579c0a0a91f64fd84b1059.camel@mediatek.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260108_011509_472082_A60DF8FB X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gVHVlc2RheSwgNiBKYW51YXJ5IDIwMjYgMTQ6MjM6NTggQ2VudHJhbCBFdXJvcGVhbiBTdGFu ZGFyZCBUaW1lIFBldGVyIFdhbmcgKOeOi+S/oeWPiykgd3JvdGU6Cj4gT24gVGh1LCAyMDI1LTEy LTE4IGF0IDEzOjU1ICswMTAwLCBOaWNvbGFzIEZyYXR0YXJvbGkgd3JvdGU6Cj4gPiAKPiA+IFJl bW92ZSB0aGUgdGksc3lzY29uLXJlc2V0IGNydWZ0Lgo+ID4gCj4gCj4gSGkgTmljb2xhcywKPiAK PiBXaHkgZG8gd2UgbmVlZCB0byByZW1vdmUgdGhlIHJlc2V0IG5vZGU/IElmIGFuIGVycm9yIG9j Y3VycyBhbmQgdGhlCj4gaG9zdCAKPiBkb2VzIG5vdCBwZXJmb3JtIGEgcmVzZXQsIGl0IGNvdWxk IGxlYWQgdG8gZXJyb3IgcmVjb3ZlcnkgZmFpbHVyZS4KCkJlY2F1c2UgaXQncyBub3QgZGVzY3Jp YmVkIGJ5IHRoZSBiaW5kaW5nLCBhbmQgYXBwZWFycyB0byBiZSBhCmRvd25zdHJlYW0gaGFjayB0 byB3b3JrIGFyb3VuZCBub3QgaGF2aW5nIHRoZSByZXNldCBjb250cm9sbGVyCnByb3Blcmx5IGRl c2NyaWJlZCBhbmQgcmVmZXJyZWQgdG8gd2l0aCBhIGByZXNldHNgIHByb3BlcnR5LgoKRXZlbiBp ZiB5b3Ugd2VyZSB0byB1c2UgYHRpLHN5c2Nvbi1yZXNldGAgdG8gZGVzY3JpYmUgYSByZXNldApj b250cm9sbGVyLCB0aGUgVUZTIGNvbnRyb2xsZXIgZHJpdmVyIHNob3VsZCBub3QgYmUgc2VhcmNo aW5nCmZvciB0aGlzIGNvbXBhdGlibGUuIEl0IHNob3VsZCBhY2Nlc3MgdGhlIHJlc2V0IHRocm91 Z2ggdGhlCnJlc2V0IEFQSS4gVGhlIGNvbW1vbiByZXNldCBjb2RlIGNhbiB0aGVuIHRha2UgY2Fy ZSBvZiBwcm9iZQpvcmRlcmluZyB3aXRob3V0IGV2ZXJ5IGRyaXZlciByZWludmVudGluZyBpdC4K Cj4gCj4gVGhhbmtzLgo+IFBldGVyCj4gCgoKCgoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QK bGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg==