From: Francis Laniel <flaniel@linux.microsoft.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Christoph Hellwig <hch@lst.de>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH 5.15.y v1 1/2] kallsyms: Make kallsyms_on_each_symbol generally available
Date: Tue, 05 Dec 2023 10:42:52 +0100 [thread overview]
Message-ID: <5996228.lOV4Wx5bFT@pwmachine> (raw)
In-Reply-To: <2023120533-washtub-data-f661@gregkh>
Hi!
Le mardi 5 décembre 2023, 00:58:38 CET Greg KH a écrit :
> On Mon, Dec 04, 2023 at 09:19:05AM +0100, Francis Laniel wrote:
> > Hi!
> >
> > Le samedi 2 décembre 2023, 00:02:58 CET Greg KH a écrit :
> > > On Fri, Dec 01, 2023 at 04:19:56PM +0100, Francis Laniel wrote:
> > > > From: Jiri Olsa <jolsa@kernel.org>
> > > >
> > > > Making kallsyms_on_each_symbol generally available, so it can be
> > > > used outside CONFIG_LIVEPATCH option in following changes.
> > > >
> > > > Rather than adding another ifdef option let's make the function
> > > > generally available (when CONFIG_KALLSYMS option is defined).
> > > >
> > > > Cc: Christoph Hellwig <hch@lst.de>
> > > > Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
> > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > > Link:
> > > > https://lore.kernel.org/r/20220510122616.2652285-2-jolsa@kernel.org
> > > > Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> > > > ---
> > > >
> > > > include/linux/kallsyms.h | 7 ++++++-
> > > > kernel/kallsyms.c | 2 --
> > > > 2 files changed, 6 insertions(+), 3 deletions(-)
> > >
> > > What is the git id of this commit in Linus's tree?
> >
> > Sorry, the commit ID is [1]:
> > d721def7392a7348ffb9f3583b264239cbd3702c
>
> Please send a new, updated series for all branches that you wish this
> series to go on, and MOST IMPORTANTLY, some sort of proof that this
> actually works this time...
>
> In other words, you need to test-build this on all arches and somehow
> run-time test it as well, good luck!
I will take a look at TuxMake to ease this process [1].
But if someone has other tools to advise, feedback would be welcomed.
> thanks,
>
> greg k-h
Best regards.
---
[1]: https://tuxmake.org/
next prev parent reply other threads:[~2023-12-05 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 15:19 [PATCH 5.15.y v1 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation Francis Laniel
2023-12-01 15:19 ` [PATCH 5.15.y v1 1/2] kallsyms: Make kallsyms_on_each_symbol generally available Francis Laniel
2023-12-01 23:02 ` Greg KH
2023-12-04 8:19 ` Francis Laniel
2023-12-04 23:58 ` Greg KH
2023-12-05 9:42 ` Francis Laniel [this message]
2023-12-01 15:19 ` [PATCH 5.15.y v1 2/2] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols Francis Laniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5996228.lOV4Wx5bFT@pwmachine \
--to=flaniel@linux.microsoft.com \
--cc=ast@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jolsa@kernel.org \
--cc=mhiramat@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.