From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Date: Fri, 18 Aug 2017 08:21:16 +0000 Subject: Re: [PATCH net-next] bpf: fix a return in sockmap_get_from_fd() Message-Id: <5996A37C.2050502@iogearbox.net> List-Id: References: <20170818071210.wyq37kura6wz6bx6@mwanda> In-Reply-To: <20170818071210.wyq37kura6wz6bx6@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Alexei Starovoitov , John Fastabend Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On 08/18/2017 09:27 AM, Dan Carpenter wrote: > "map" is a valid pointer. We wanted to return "err" instead. Also > let's return a zero literal at the end. > > Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") > Signed-off-by: Dan Carpenter Acked-by: Daniel Borkmann From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH net-next] bpf: fix a return in sockmap_get_from_fd() Date: Fri, 18 Aug 2017 10:21:16 +0200 Message-ID: <5996A37C.2050502@iogearbox.net> References: <20170818071210.wyq37kura6wz6bx6@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter , Alexei Starovoitov , John Fastabend Return-path: In-Reply-To: <20170818071210.wyq37kura6wz6bx6@mwanda> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 08/18/2017 09:27 AM, Dan Carpenter wrote: > "map" is a valid pointer. We wanted to return "err" instead. Also > let's return a zero literal at the end. > > Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") > Signed-off-by: Dan Carpenter Acked-by: Daniel Borkmann