From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Message-ID: <5996A626.5040303@rock-chips.com> Date: Fri, 18 Aug 2017 16:32:38 +0800 From: jeffy MIME-Version: 1.0 To: Shawn Lin Subject: Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq References: <20170817120431.12398-1-jeffy.chen@rock-chips.com> <20170817120431.12398-2-jeffy.chen@rock-chips.com> <5e3accf1-6f84-861f-f647-628322bb7841@rock-chips.com> In-Reply-To: <5e3accf1-6f84-861f-f647-628322bb7841@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-pci@vger.kernel.org, briannorris@chromium.org, linux-kernel@vger.kernel.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi Shawn, On 08/18/2017 03:23 PM, Shawn Lin wrote: >> >> @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct >> platform_device *pdev) >> struct device *dev = &pdev->dev; >> struct rockchip_pcie *rockchip = dev_get_drvdata(dev); >> + dev_pm_clear_wake_irq(dev); >> + device_init_wakeup(dev, false); >> + > > Looks good overall but I think we need this on the > error handling path of rockchip_pcie_probe as well? hmm, right, will fix it, thanks. and i also notice some other missing error handling, will fix them too:) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Date: Fri, 18 Aug 2017 16:32:38 +0800 Message-ID: <5996A626.5040303@rock-chips.com> References: <20170817120431.12398-1-jeffy.chen@rock-chips.com> <20170817120431.12398-2-jeffy.chen@rock-chips.com> <5e3accf1-6f84-861f-f647-628322bb7841@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5e3accf1-6f84-861f-f647-628322bb7841@rock-chips.com> Sender: linux-pci-owner@vger.kernel.org To: Shawn Lin Cc: linux-kernel@vger.kernel.org, bhelgaas@google.com, briannorris@chromium.org, dianders@chromium.org, Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org Hi Shawn, On 08/18/2017 03:23 PM, Shawn Lin wrote: >> >> @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct >> platform_device *pdev) >> struct device *dev = &pdev->dev; >> struct rockchip_pcie *rockchip = dev_get_drvdata(dev); >> + dev_pm_clear_wake_irq(dev); >> + device_init_wakeup(dev, false); >> + > > Looks good overall but I think we need this on the > error handling path of rockchip_pcie_probe as well? hmm, right, will fix it, thanks. and i also notice some other missing error handling, will fix them too:) From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (jeffy) Date: Fri, 18 Aug 2017 16:32:38 +0800 Subject: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq In-Reply-To: <5e3accf1-6f84-861f-f647-628322bb7841@rock-chips.com> References: <20170817120431.12398-1-jeffy.chen@rock-chips.com> <20170817120431.12398-2-jeffy.chen@rock-chips.com> <5e3accf1-6f84-861f-f647-628322bb7841@rock-chips.com> Message-ID: <5996A626.5040303@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Shawn, On 08/18/2017 03:23 PM, Shawn Lin wrote: >> >> @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct >> platform_device *pdev) >> struct device *dev = &pdev->dev; >> struct rockchip_pcie *rockchip = dev_get_drvdata(dev); >> + dev_pm_clear_wake_irq(dev); >> + device_init_wakeup(dev, false); >> + > > Looks good overall but I think we need this on the > error handling path of rockchip_pcie_probe as well? hmm, right, will fix it, thanks. and i also notice some other missing error handling, will fix them too:)