From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay Date: Tue, 22 Aug 2017 19:01:52 +0800 Message-ID: <599C0F20.7080807@rock-chips.com> References: <20170822075729.8438-1-jeffy.chen@rock-chips.com> <20170822075729.8438-2-jeffy.chen@rock-chips.com> <20170822103241.wjiycavsro7abknj@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.130]) by alsa0.perex.cz (Postfix) with ESMTP id 8D53A267578 for ; Tue, 22 Aug 2017 13:01:59 +0200 (CEST) In-Reply-To: <20170822103241.wjiycavsro7abknj@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, mengdong.lin@linux.intel.com, heiko@sntech.de, Liam Girdwood , Oder Chiou , briannorris@chromium.org, linux-kernel@vger.kernel.org, Rob Herring , dianders@chromium.org, linux-rockchip@lists.infradead.org, mka@chromium.org, Takashi Iwai , dgreid@chromium.org, lars@metafoo.de, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org Hi Mark, On 08/22/2017 06:32 PM, Mark Brown wrote: > On Tue, Aug 22, 2017 at 03:57:20PM +0800, Jeffy Chen wrote: >> This property is no longer used. > > I would still rather keep the existing property documented (the binding > does need to be fixed) than remove it. It's better practice and it's > not costing a huge amount. > sorry, i should explain more in the commit msg... just to clarify, this property is replaced by "realtek,dmic-init-delay-ms" in rt5514 driver: a5461fd6c8f7 ASoC: rt5514: Add the DMIC initial delay to wait it ready. which does exactly the same thing as the old one: perform a delay after set clk... i can do that if you still insist to keep it, since it's harmless :) From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (jeffy) Date: Tue, 22 Aug 2017 19:01:52 +0800 Subject: [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay In-Reply-To: <20170822103241.wjiycavsro7abknj@sirena.org.uk> References: <20170822075729.8438-1-jeffy.chen@rock-chips.com> <20170822075729.8438-2-jeffy.chen@rock-chips.com> <20170822103241.wjiycavsro7abknj@sirena.org.uk> Message-ID: <599C0F20.7080807@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 08/22/2017 06:32 PM, Mark Brown wrote: > On Tue, Aug 22, 2017 at 03:57:20PM +0800, Jeffy Chen wrote: >> This property is no longer used. > > I would still rather keep the existing property documented (the binding > does need to be fixed) than remove it. It's better practice and it's > not costing a huge amount. > sorry, i should explain more in the commit msg... just to clarify, this property is replaced by "realtek,dmic-init-delay-ms" in rt5514 driver: a5461fd6c8f7 ASoC: rt5514: Add the DMIC initial delay to wait it ready. which does exactly the same thing as the old one: perform a delay after set clk... i can do that if you still insist to keep it, since it's harmless :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932598AbdHVLCF (ORCPT ); Tue, 22 Aug 2017 07:02:05 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:33162 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932427AbdHVLCD (ORCPT ); Tue, 22 Aug 2017 07:02:03 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: broonie@kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <8082492ac4f42bd714f7b3050a340b00> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <599C0F20.7080807@rock-chips.com> Date: Tue, 22 Aug 2017 19:01:52 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Mark Brown CC: linux-kernel@vger.kernel.org, dgreid@chromium.org, heiko@sntech.de, briannorris@chromium.org, mengdong.lin@linux.intel.com, mka@chromium.org, lars@metafoo.de, dianders@chromium.org, Jaroslav Kysela , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, Liam Girdwood , Takashi Iwai , Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org, Oder Chiou Subject: Re: [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay References: <20170822075729.8438-1-jeffy.chen@rock-chips.com> <20170822075729.8438-2-jeffy.chen@rock-chips.com> <20170822103241.wjiycavsro7abknj@sirena.org.uk> In-Reply-To: <20170822103241.wjiycavsro7abknj@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 08/22/2017 06:32 PM, Mark Brown wrote: > On Tue, Aug 22, 2017 at 03:57:20PM +0800, Jeffy Chen wrote: >> This property is no longer used. > > I would still rather keep the existing property documented (the binding > does need to be fixed) than remove it. It's better practice and it's > not costing a huge amount. > sorry, i should explain more in the commit msg... just to clarify, this property is replaced by "realtek,dmic-init-delay-ms" in rt5514 driver: a5461fd6c8f7 ASoC: rt5514: Add the DMIC initial delay to wait it ready. which does exactly the same thing as the old one: perform a delay after set clk... i can do that if you still insist to keep it, since it's harmless :)