From: jeffy <jeffy.chen@rock-chips.com>
To: Donglin Peng <dolinux.peng@gmail.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
tiwai@suse.de, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name
Date: Thu, 24 Aug 2017 12:44:12 +0800 [thread overview]
Message-ID: <599E599C.1060308@rock-chips.com> (raw)
In-Reply-To: <CAErzpmvnDs-WBRVCn+wdQw2cxiT+h0gdBci5UqPXEvffRtBmMw@mail.gmail.com>
Hi Dong,
Thanks for noticing, will send new patch soon :)
On 08/24/2017 11:46 AM, Donglin Peng wrote:
> On Thu, Aug 24, 2017 at 11:34 AM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
>> list_for_each_entry(dai, &component->dai_list, list) {
>> if (dlc->dai_name && strcmp(dai->name, dlc->dai_name)
>> - && strcmp(dai->driver->name, dlc->dai_name))
>> + && (!dai->driver->name
>> + || !strcmp(dai->driver->name, dlc->dai_name))
>> continue;
>
> If the dai->driver->name is match with the dlc->dai_name, does it need
> to continue?
hmm, sorry, i did this in a hurry, should setup my board and test it..
>
>>
>> return dai;
>
>
>
next prev parent reply other threads:[~2017-08-24 4:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 3:34 [PATCH v2] ASoC: Add a sanity check before using dai driver name Jeffy Chen
2017-08-24 3:46 ` Donglin Peng
2017-08-24 4:44 ` jeffy [this message]
2017-08-26 14:13 ` kbuild test robot
2017-08-26 14:13 ` kbuild test robot
2017-08-26 15:09 ` Donglin Peng
2017-08-27 12:19 ` Mark Brown
2017-08-27 12:19 ` Mark Brown
2017-08-27 13:54 ` Donglin Peng
2017-08-27 14:26 ` Mark Brown
2017-08-27 14:26 ` Mark Brown
2017-08-27 14:31 ` Jeffy Chen
2017-08-27 14:34 ` Mark Brown
2017-08-27 14:34 ` Mark Brown
2017-08-27 22:21 ` jeffy
2017-08-28 1:47 ` Donglin Peng
2017-08-28 1:47 ` Donglin Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599E599C.1060308@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dolinux.peng@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.