From: Daniel Borkmann <daniel@iogearbox.net>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [Patch net-next] net_sched: add reverse binding for tc class
Date: Wed, 30 Aug 2017 23:48:40 +0200 [thread overview]
Message-ID: <59A732B8.6020405@iogearbox.net> (raw)
In-Reply-To: <20170830213036.24250-1-xiyou.wangcong@gmail.com>
On 08/30/2017 11:30 PM, Cong Wang wrote:
[...]
> Note, we still can NOT totally get rid of those class lookup in
> ->enqueue() because cgroup and flow filters have no way to determine
> the classid at setup time, they still have to go through dynamic lookup.
[...]
> ---
> include/net/sch_generic.h | 1 +
> net/sched/cls_basic.c | 9 +++++++
> net/sched/cls_bpf.c | 9 +++++++
Same is for cls_bpf as well, so bind_class wouldn't work there
either as we could return dynamic classids. bind_class cannot
be added here, too.
> net/sched/cls_flower.c | 9 +++++++
> net/sched/cls_fw.c | 9 +++++++
> net/sched/cls_matchall.c | 9 +++++++
> net/sched/cls_route.c | 9 +++++++
> net/sched/cls_rsvp.h | 9 +++++++
> net/sched/cls_tcindex.c | 9 +++++++
> net/sched/cls_u32.c | 9 +++++++
> net/sched/sch_api.c | 68 +++++++++++++++++++++++++++++++++++++++++++++--
> 11 files changed, 148 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2017-08-30 21:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 21:30 [Patch net-next] net_sched: add reverse binding for tc class Cong Wang
2017-08-30 21:48 ` Daniel Borkmann [this message]
2017-08-30 22:01 ` Cong Wang
2017-08-30 22:22 ` Daniel Borkmann
2017-08-30 22:45 ` Daniel Borkmann
2017-08-30 23:15 ` Cong Wang
2017-08-31 18:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59A732B8.6020405@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.