From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: Possible regression between 4.9 and 4.13 To: Mason , Greg Kroah-Hartman References: <599D62EA.7050100@linux.intel.com> <8ac92197-907a-282b-2165-f50d1b09bd55@free.fr> <61d34811-f17c-6faf-252f-c4c81feb9e89@free.fr> <59A3D6BF.7010400@linux.intel.com> <0b089b17-00fc-5a7c-baa3-e6141029b191@free.fr> <59A56C15.2000403@linux.intel.com> <20170829235310.GA20214@wunner.de> <20170830060237.GA2782@kroah.com> <678490ce-9381-e63e-7a12-33d3eff7f894@free.fr> <20170830090633.GA1208@kroah.com> <1e3bde27-5597-41ed-11d1-0450b17f2344@free.fr> Cc: Lukas Wunner , Felipe Balbi , linux-pci , linux-usb , Linux ARM , Bjorn Helgaas , Alan Stern From: Mathias Nyman Message-ID: <59A7F5B1.7060501@linux.intel.com> Date: Thu, 31 Aug 2017 14:40:33 +0300 MIME-Version: 1.0 In-Reply-To: <1e3bde27-5597-41ed-11d1-0450b17f2344@free.fr> Content-Type: text/plain; charset=utf-8; format=flowed List-ID: On 31.08.2017 12:39, Mason wrote: > On 30/08/2017 11:06, Greg Kroah-Hartman wrote: > >> On Wed, Aug 30, 2017 at 10:55:37AM +0200, Mason wrote: >> >>> On 30/08/2017 08:02, Greg Kroah-Hartman wrote: >>> >>>> To get back to the original issue here, the hardware seems to have died, >>>> the driver stops talking to it, and all is good. The "regression" here >>>> is that we now properly can determine that the hardware is crap. >>> >>> Before 4.12, when I unplugged my USB3 Flash drive, Linux would >>> detect a few "Uncorrected Non-Fatal errors" via AER, but it was >>> still possible to plug the drive back in. >>> >>> Since 4.12, once I unplug the drive, the whole USB3 card is marked >>> as dead (all 4 ports), and I can no longer plug anything in (not even >>> the USB2 drive that didn't have any issues, IIRC). >>> >>> It seems a bit premature to "mark as dead" something that remains >>> functional, doesn't it? >> >> I agree, but if the device sends all ones, it's a good indication it is >> really dead, right? Or something is wrong with it. > > I wouldn't call it dead if I can plug the drive back in, and have > it working... But I agree that something fishy is happening... > >>> Disclaimer, there are many variables in this setup, and I've only >>> tested a small fraction of the problem space: only one system, >>> only one USB3 board, only one USB3 Flash drive. >> >> Did you ever happen to narrow this down to a single git commit using >> 'git bisect'? I can't remember what happened in the beginning of this >> thread... > > Mathias pointed out d9f11ba9f107aa335091ab8d7ba5eea714e46e8b > That patch only changes how xhci reacts to reading 0xffffffff. we used to just returned -ENODEV, but after patch we assume hardware is broken or removed. -Mathias From mboxrd@z Thu Jan 1 00:00:00 1970 From: mathias.nyman@linux.intel.com (Mathias Nyman) Date: Thu, 31 Aug 2017 14:40:33 +0300 Subject: Possible regression between 4.9 and 4.13 In-Reply-To: <1e3bde27-5597-41ed-11d1-0450b17f2344@free.fr> References: <599D62EA.7050100@linux.intel.com> <8ac92197-907a-282b-2165-f50d1b09bd55@free.fr> <61d34811-f17c-6faf-252f-c4c81feb9e89@free.fr> <59A3D6BF.7010400@linux.intel.com> <0b089b17-00fc-5a7c-baa3-e6141029b191@free.fr> <59A56C15.2000403@linux.intel.com> <20170829235310.GA20214@wunner.de> <20170830060237.GA2782@kroah.com> <678490ce-9381-e63e-7a12-33d3eff7f894@free.fr> <20170830090633.GA1208@kroah.com> <1e3bde27-5597-41ed-11d1-0450b17f2344@free.fr> Message-ID: <59A7F5B1.7060501@linux.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 31.08.2017 12:39, Mason wrote: > On 30/08/2017 11:06, Greg Kroah-Hartman wrote: > >> On Wed, Aug 30, 2017 at 10:55:37AM +0200, Mason wrote: >> >>> On 30/08/2017 08:02, Greg Kroah-Hartman wrote: >>> >>>> To get back to the original issue here, the hardware seems to have died, >>>> the driver stops talking to it, and all is good. The "regression" here >>>> is that we now properly can determine that the hardware is crap. >>> >>> Before 4.12, when I unplugged my USB3 Flash drive, Linux would >>> detect a few "Uncorrected Non-Fatal errors" via AER, but it was >>> still possible to plug the drive back in. >>> >>> Since 4.12, once I unplug the drive, the whole USB3 card is marked >>> as dead (all 4 ports), and I can no longer plug anything in (not even >>> the USB2 drive that didn't have any issues, IIRC). >>> >>> It seems a bit premature to "mark as dead" something that remains >>> functional, doesn't it? >> >> I agree, but if the device sends all ones, it's a good indication it is >> really dead, right? Or something is wrong with it. > > I wouldn't call it dead if I can plug the drive back in, and have > it working... But I agree that something fishy is happening... > >>> Disclaimer, there are many variables in this setup, and I've only >>> tested a small fraction of the problem space: only one system, >>> only one USB3 board, only one USB3 Flash drive. >> >> Did you ever happen to narrow this down to a single git commit using >> 'git bisect'? I can't remember what happened in the beginning of this >> thread... > > Mathias pointed out d9f11ba9f107aa335091ab8d7ba5eea714e46e8b > That patch only changes how xhci reacts to reading 0xffffffff. we used to just returned -ENODEV, but after patch we assume hardware is broken or removed. -Mathias