From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>,
amd-gfx mailing list
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: GFX ring names
Date: Fri, 1 Sep 2017 09:45:36 +0800 [thread overview]
Message-ID: <59A8BBC0.7010005@amd.com> (raw)
In-Reply-To: <c3c382ff-bef0-dd69-9022-de66bb2ac441-5C7GfCeVMHo@public.gmane.org>
On 08/31/2017 08:53 PM, Tom St Denis wrote:
> Working on a series of tidy up patches for gfx_v9 and found this block in
> gfx_v9_0_sw_init().
>
> for (i = 0; i < adev->gfx.num_gfx_rings; i++) {
> ring = &adev->gfx.gfx_ring[i];
> ring->ring_obj = NULL;
> sprintf(ring->name, "gfx");
>
> Won't that make a series of rings all with the same name?
Yes, it will.
Generally we always have one gfx ring, so it's acceptable for now.
* adev->gfx.num_gfx_rings = GFX9_NUM_GFX_RINGS
Additionally, as all rings here belong to gfx, naming "gfx" also acceptable.
(Perhaps gfx[i] is a better name when we have more rings)
Regards,
Jerry
>
> Tom
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-09-01 1:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 12:53 GFX ring names Tom St Denis
[not found] ` <c3c382ff-bef0-dd69-9022-de66bb2ac441-5C7GfCeVMHo@public.gmane.org>
2017-09-01 1:45 ` Zhang, Jerry (Junwei) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59A8BBC0.7010005@amd.com \
--to=jerry.zhang-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=tom.stdenis-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.