From: jeffy <jeffy.chen@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-kernel@vger.kernel.org, dgreid@chromium.org,
briannorris@chromium.org, mka@chromium.org,
dianders@chromium.org, devicetree@vger.kernel.org,
Klaus Goger <klaus.goger@theobroma-systems.com>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Caesar Wang <wxt@rock-chips.com>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru
Date: Tue, 05 Sep 2017 12:26:22 +0800 [thread overview]
Message-ID: <59AE276E.6090100@rock-chips.com> (raw)
In-Reply-To: <3717071.LIWpZa6hqd@diego>
Hi Heiko,
On 09/05/2017 06:33 AM, Heiko Stübner wrote:
> Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy:
>> On 08/30/2017 09:30 PM, Heiko Stübner wrote:
>>>>> - compatible = "realtek,rt5514";
>>>>> + compatible = "realtek,rt5514", "realtek,rt5514-i2c";
>>>
>>> the rt5514-i2c and -spi compatibles should be documented in the
>>> binding-txt
>>> of the chip, but I haven't found any mention of this.
>>>
>>>
>>> Heiko
>>
>> these compatibles are only used for our snd driver to detect rt5514 i2c
>> driver and rt5514 spi driver, suggested by Matthias at
>> https://patchwork.kernel.org/patch/9904731/
>>
>> should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding
>> document?
>
> You're introducing new bindings for the codec, so they should of course
> part of the rt5514 binding.
ok, will do that.
and it looks like there's no binding for rt5514-spi, will add it too :)
>
>
> Heiko
>
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (jeffy)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru
Date: Tue, 05 Sep 2017 12:26:22 +0800 [thread overview]
Message-ID: <59AE276E.6090100@rock-chips.com> (raw)
In-Reply-To: <3717071.LIWpZa6hqd@diego>
Hi Heiko,
On 09/05/2017 06:33 AM, Heiko St?bner wrote:
> Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy:
>> On 08/30/2017 09:30 PM, Heiko St?bner wrote:
>>>>> - compatible = "realtek,rt5514";
>>>>> + compatible = "realtek,rt5514", "realtek,rt5514-i2c";
>>>
>>> the rt5514-i2c and -spi compatibles should be documented in the
>>> binding-txt
>>> of the chip, but I haven't found any mention of this.
>>>
>>>
>>> Heiko
>>
>> these compatibles are only used for our snd driver to detect rt5514 i2c
>> driver and rt5514 spi driver, suggested by Matthias at
>> https://patchwork.kernel.org/patch/9904731/
>>
>> should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding
>> document?
>
> You're introducing new bindings for the codec, so they should of course
> part of the rt5514 binding.
ok, will do that.
and it looks like there's no binding for rt5514-spi, will add it too :)
>
>
> Heiko
>
>
>
>
next prev parent reply other threads:[~2017-09-05 4:26 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 4:52 [RESENT PATCH v7 0/7] ASoC: rockchip: Parse dai links from dts Jeffy Chen
2017-08-24 4:52 ` Jeffy Chen
2017-08-24 4:52 ` Jeffy Chen
2017-08-24 4:52 ` [RESENT PATCH v7 1/7] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp Jeffy Chen
2017-08-24 4:52 ` Jeffy Chen
2017-08-24 21:19 ` Matthias Kaehlcke
2017-08-24 21:19 ` Matthias Kaehlcke
2017-08-29 19:29 ` Applied "ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp" to the asoc tree Mark Brown
2017-08-29 19:29 ` Mark Brown
2017-08-29 19:29 ` Mark Brown
2017-08-29 19:29 ` Mark Brown
2017-08-24 4:52 ` [RESENT PATCH v7 2/7] arm64: dts: rockchip: Add rt5514 dsp for Gru Jeffy Chen
2017-08-24 4:52 ` Jeffy Chen
[not found] ` <20170824045227.15504-3-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-09-09 11:13 ` Heiko Stuebner
2017-09-09 11:13 ` Heiko Stuebner
2017-09-09 11:13 ` Heiko Stuebner
2017-09-09 11:45 ` Heiko Stuebner
2017-09-09 11:45 ` Heiko Stuebner
2017-09-09 11:45 ` Heiko Stuebner
2017-08-24 4:52 ` [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible " Jeffy Chen
2017-08-24 4:52 ` Jeffy Chen
[not found] ` <20170824045227.15504-4-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-30 13:30 ` Heiko Stübner
2017-08-30 13:30 ` Heiko Stübner
2017-08-30 13:30 ` Heiko Stübner
2017-08-30 17:00 ` jeffy
2017-08-30 17:00 ` jeffy
2017-08-30 17:00 ` jeffy
[not found] ` <59A6EF3C.5090308-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-09-04 22:33 ` Heiko Stübner
2017-09-04 22:33 ` Heiko Stübner
2017-09-04 22:33 ` Heiko Stübner
2017-09-05 4:26 ` jeffy [this message]
2017-09-05 4:26 ` jeffy
2017-08-24 4:52 ` [RESENT PATCH v7 4/7] ASoC: rockchip: Parse dai links from dts Jeffy Chen
2017-08-24 4:52 ` Jeffy Chen
2017-08-29 19:28 ` Applied "ASoC: rockchip: Parse dai links from dts" to the asoc tree Mark Brown
2017-08-29 19:28 ` Mark Brown
2017-08-29 19:28 ` Mark Brown
2017-08-29 19:28 ` Mark Brown
2017-08-24 4:52 ` [RESENT PATCH v7 5/7] ASoC: rockchip: Add support for DP codec Jeffy Chen
2017-08-24 4:52 ` Jeffy Chen
2017-08-24 4:52 ` [RESENT PATCH v7 6/7] ASoC: rockchip: Add support for DMIC codec Jeffy Chen
2017-08-24 4:52 ` Jeffy Chen
2017-08-24 4:52 ` [RESENT PATCH v7 7/7] dt-bindings: ASoC: rockchip: Update description of rockchip,codec Jeffy Chen
2017-08-24 4:52 ` [RESENT PATCH v7 7/7] dt-bindings: ASoC: rockchip: Update description of rockchip, codec Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59AE276E.6090100@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.