All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] clk: samsung: Properly propagate flags in __PLL macro
Date: Fri, 15 Sep 2017 11:49:11 +0900	[thread overview]
Message-ID: <59BB3FA7.3070000@samsung.com> (raw)
In-Reply-To: <1505399897-4840-1-git-send-email-m.szyprowski@samsung.com>

On 2017년 09월 14일 23:38, Marek Szyprowski wrote:
> All users of __PLL macro already provide flags parameter, so don't
> overwrite it unconditionally with CLK_GET_RATE_NOCACHE.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/clk/samsung/clk.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h
> index b8ca0dd3a38b..d5f0d3f818b6 100644
> --- a/drivers/clk/samsung/clk.h
> +++ b/drivers/clk/samsung/clk.h
> @@ -305,7 +305,7 @@ struct samsung_pll_clock {
>  		.dev_name	= _dname,				\
>  		.name		= _name,				\
>  		.parent_name	= _pname,				\
> -		.flags		= CLK_GET_RATE_NOCACHE,			\
> +		.flags		= _flags,				\
>  		.con_offset	= _con,					\
>  		.lock_offset	= _lock,				\
>  		.rate_table	= _rtable,				\
> 

Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

  reply	other threads:[~2017-09-15  2:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170914143824eucas1p1e811c6c4c32a2253aebad9a27d4182d5@eucas1p1.samsung.com>
2017-09-14 14:38 ` [PATCH] clk: samsung: Properly propagate flags in __PLL macro Marek Szyprowski
2017-09-15  2:49   ` Chanwoo Choi [this message]
2017-10-03 10:29   ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59BB3FA7.3070000@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.