From: Mike Christie <mchristi@redhat.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] target: Add netlink command reply supported option for each device
Date: Sat, 16 Sep 2017 01:01:18 +0000 [thread overview]
Message-ID: <59BC77DE.2030301@redhat.com> (raw)
In-Reply-To: <20170913050122.13731-1-nakayamakenjiro@gmail.com>
On 09/13/2017 12:01 AM, Kenjiro Nakayama wrote:
> Currently netlink command reply support option
> (TCMU_ATTR_SUPP_KERN_CMD_REPLY) can be enabled only on module
> scope. Because of that, once an application enables the netlink
> command reply support, all applications using target_core_user.ko
> would be expected to support the netlink reply. To make matters worse,
> users will not be able to add a device via configfs manually.
>
> To fix these issues, this patch adds an option to make netlink command
> reply disabled on each device through configfs. Original
> TCMU_ATTR_SUPP_KERN_CMD_REPLY is still enabled on module scope to keep
> backward-compatibility and used by default, however once users set
> nl_reply_supported=<NAGATIVE_VALUE> via configfs for a particular
> device, the device disables the netlink command reply support.
>
Patch is ok with me.
Reviewed-by: Mike Christie <mchristi@redhat.com>
prev parent reply other threads:[~2017-09-16 1:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 5:01 [PATCH] target: Add netlink command reply supported option for each device Kenjiro Nakayama
2017-09-13 15:10 ` Bryant G. Ly
2017-09-13 15:58 ` Mike Christie
2017-09-13 16:04 ` Mike Christie
2017-09-13 18:35 ` Nakayama Kenjiro
2017-09-13 18:43 ` Mike Christie
2017-09-13 19:27 ` Nakayama Kenjiro
2017-09-13 19:31 ` Mike Christie
2017-09-16 1:01 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59BC77DE.2030301@redhat.com \
--to=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.