From: Daniel Borkmann <daniel@iogearbox.net>
To: Craig Gallek <kraigatgoog@gmail.com>,
Daniel Mack <daniel@zonque.org>, Alexei Starovoitov <ast@fb.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] bpf: Add uniqueness invariant to trivial lpm test implementation
Date: Tue, 19 Sep 2017 18:12:34 +0200 [thread overview]
Message-ID: <59C141F2.10104@iogearbox.net> (raw)
In-Reply-To: <20170918193057.37644-3-kraigatgoog@gmail.com>
On 09/18/2017 09:30 PM, Craig Gallek wrote:
> From: Craig Gallek <kraig@google.com>
>
> The 'trivial' lpm implementation in this test allows equivalent nodes
> to be added (that is, nodes consisting of the same prefix and prefix
> length). For lookup operations, this is fine because insertion happens
> at the head of the (singly linked) list and the first, best match is
> returned. In order to support deletion, the tlpm data structue must
> first enforce uniqueness. This change modifies the insertion algorithm
> to search for equivalent nodes and remove them. Note: the
> BPF_MAP_TYPE_LPM_TRIE already has a uniqueness invariant that is
> implemented as node replacement.
>
> Signed-off-by: Craig Gallek <kraig@google.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-09-19 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 19:30 [PATCH net-next 0/3] Implement delete for BPF LPM trie Craig Gallek
2017-09-18 19:30 ` [PATCH net-next 1/3] bpf: Implement map_delete_elem for BPF_MAP_TYPE_LPM_TRIE Craig Gallek
2017-09-18 22:53 ` Alexei Starovoitov
2017-09-19 15:08 ` Craig Gallek
2017-09-19 16:12 ` Daniel Borkmann
2017-09-19 19:48 ` Daniel Mack
2017-09-18 19:30 ` [PATCH net-next 2/3] bpf: Add uniqueness invariant to trivial lpm test implementation Craig Gallek
2017-09-18 22:54 ` Alexei Starovoitov
2017-09-19 16:12 ` Daniel Borkmann [this message]
2017-09-18 19:30 ` [PATCH net-next 3/3] bpf: Test deletion in BPF_MAP_TYPE_LPM_TRIE Craig Gallek
2017-09-18 22:54 ` Alexei Starovoitov
2017-09-19 16:12 ` Daniel Borkmann
2017-09-19 20:55 ` [PATCH net-next 0/3] Implement delete for BPF LPM trie David Miller
2017-09-19 21:13 ` Daniel Mack
2017-09-19 21:16 ` Craig Gallek
2017-09-19 21:29 ` David Miller
2017-09-19 21:31 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59C141F2.10104@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=kraigatgoog@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.