From: Daniel Borkmann <daniel@iogearbox.net>
To: Joel Fernandes <joelaf@google.com>, linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org, alison@she-devel.com, juri.lelli@arm.com,
fengc@google.com, davem@davemloft.net, ast@kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v4 3/4] samples/bpf: Fix pt_regs issues when cross-compiling
Date: Wed, 20 Sep 2017 23:25:01 +0200 [thread overview]
Message-ID: <59C2DCAD.3090309@iogearbox.net> (raw)
In-Reply-To: <20170920161159.25747-3-joelaf@google.com>
On 09/20/2017 06:11 PM, Joel Fernandes wrote:
> BPF samples fail to build when cross-compiling for ARM64 because of incorrect
> pt_regs param selection. This is because clang defines __x86_64__ and
> bpf_headers thinks we're building for x86. Since clang is building for the BPF
> target, it shouldn't make assumptions about what target the BPF program is
> going to run on. To fix this, lets pass ARCH so the header knows which target
> the BPF program is being compiled for and can use the correct pt_regs code.
>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
> Signed-off-by: Joel Fernandes <joelaf@google.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-09-20 21:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 16:11 [PATCH v4 1/4] samples/bpf: Use getppid instead of getpgrp for array map stress Joel Fernandes
2017-09-20 16:11 ` [PATCH v4 2/4] samples/bpf: Enable cross compiler support Joel Fernandes
2017-09-20 21:24 ` Daniel Borkmann
2017-09-20 16:11 ` [PATCH v4 3/4] samples/bpf: Fix pt_regs issues when cross-compiling Joel Fernandes
2017-09-20 21:25 ` Daniel Borkmann [this message]
2017-09-20 16:11 ` [PATCH v4 4/4] samples/bpf: Add documentation on cross compilation Joel Fernandes
2017-09-20 16:50 ` Randy Dunlap
2017-09-20 21:25 ` Daniel Borkmann
2017-09-20 21:24 ` [PATCH v4 1/4] samples/bpf: Use getppid instead of getpgrp for array map stress Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59C2DCAD.3090309@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alison@she-devel.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=fengc@google.com \
--cc=joelaf@google.com \
--cc=juri.lelli@arm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.