From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from www62.your-server.de ([213.133.104.62]:51713 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934668AbdIYLCI (ORCPT ); Mon, 25 Sep 2017 07:02:08 -0400 Message-ID: <59C8E22C.3000609@iogearbox.net> Date: Mon, 25 Sep 2017 13:02:04 +0200 From: Daniel Borkmann MIME-Version: 1.0 Subject: Re: libbpf missing set_link_xdp_fd ? References: <1506276431.21618.2.camel@regit.org> <20170925112502.1879734a@redhat.com> <59C8CF39.7030405@iogearbox.net> In-Reply-To: <59C8CF39.7030405@iogearbox.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: xdp-newbies-owner@vger.kernel.org List-ID: To: Jesper Dangaard Brouer , Eric Leblond Cc: xdp-newbies@vger.kernel.org, wangnan0@huawei.com, Daniel Borkmann , Alexei Starovoitov On 09/25/2017 11:41 AM, Daniel Borkmann wrote: > On 09/25/2017 11:25 AM, Jesper Dangaard Brouer wrote: >> On Sun, 24 Sep 2017 20:07:11 +0200 >> Eric Leblond wrote: >> >>> Hello, >>> >>> bpf_load is implementing the set_link_xdp_fd() function and it seems >>> this function is not available in libbpf. >> >> I also ran into this problem, when I wanted to switch my XDP programs >> into using tools/lib/bpf/. > > Right. > >> E.g.: https://github.com/netoptimizer/prototype-kernel/commit/5397e596c30416763 >> >>> Should it be the case or should it be part of another library ? >> >> I'm not sure... maybe Alexei, Daniel or Wang have an opinion? > > It seems that none of the actual attach infra is handled in > tools/lib/bpf/, meaning neither attaching the fd to kprobes/ > uprobes/tracepoints nor tc or xdp, so adding a special case > only for xdp into the lib feels that we probably might be better > off putting this either into its own mini lib on top of that, That could potentially go to tools/lib/xdp/, probably would be the best option. > or as a small helper included in the samples / selftests and > the like where its needed. > > Best, > Daniel