diff for duplicates of <59CF4389.6050103@huawei.com> diff --git a/a/1.txt b/N1/1.txt index 77aeb13..89a691f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,7 +5,7 @@ Acked-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> On 2017/9/30 4:13, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > -> For the case where hr_qp->state = IB_QPS_RESET, an uninitialized +> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized > value in ret is being returned by function hns_roce_v2_query_qp. > Fix this by setting ret to 0 for this specific return condition. > @@ -22,7 +22,7 @@ On 2017/9/30 4:13, Colin King wrote: > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > @@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr, > -> if (hr_qp->state = IB_QPS_RESET) { +> if (hr_qp->state == IB_QPS_RESET) { > qp_attr->qp_state = IB_QPS_RESET; > + ret = 0; > goto done; diff --git a/a/content_digest b/N1/content_digest index 7dda79b..ea6a137 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020170929201308.4704-1-colin.king@canonical.com\0" "From\0Wei Hu (Xavier) <xavier.huwei@huawei.com>\0" "Subject\0Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value\0" - "Date\0Sat, 30 Sep 2017 07:11:05 +0000\0" + "Date\0Sat, 30 Sep 2017 15:11:05 +0800\0" "To\0Colin King <colin.king@canonical.com>" Doug Ledford <dledford@redhat.com> " Sean Hefty <sean.hefty@intel.com>\0" @@ -19,7 +19,7 @@ "On 2017/9/30 4:13, Colin King wrote:\n" "> From: Colin Ian King <colin.king@canonical.com>\n" ">\n" - "> For the case where hr_qp->state = IB_QPS_RESET, an uninitialized\n" + "> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized\n" "> value in ret is being returned by function hns_roce_v2_query_qp.\n" "> Fix this by setting ret to 0 for this specific return condition.\n" ">\n" @@ -36,11 +36,11 @@ "> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c\n" "> @@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,\n" "> \n" - "> \tif (hr_qp->state = IB_QPS_RESET) {\n" + "> \tif (hr_qp->state == IB_QPS_RESET) {\n" "> \t\tqp_attr->qp_state = IB_QPS_RESET;\n" "> +\t\tret = 0;\n" "> \t\tgoto done;\n" "> \t}\n" > -2c84b7ffeaec038e2e752115e2ce9e579497fb8d0daa213b4ddbdc511b15115c +ed13d1408e2859ff136a6c5160d5d01c93ed17da349a6caa02243518b0d6e988
diff --git a/a/1.txt b/N2/1.txt index 77aeb13..89a691f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -5,7 +5,7 @@ Acked-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> On 2017/9/30 4:13, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > -> For the case where hr_qp->state = IB_QPS_RESET, an uninitialized +> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized > value in ret is being returned by function hns_roce_v2_query_qp. > Fix this by setting ret to 0 for this specific return condition. > @@ -22,7 +22,7 @@ On 2017/9/30 4:13, Colin King wrote: > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > @@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr, > -> if (hr_qp->state = IB_QPS_RESET) { +> if (hr_qp->state == IB_QPS_RESET) { > qp_attr->qp_state = IB_QPS_RESET; > + ret = 0; > goto done; diff --git a/a/content_digest b/N2/content_digest index 7dda79b..994c750 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,15 +1,15 @@ "ref\020170929201308.4704-1-colin.king@canonical.com\0" "From\0Wei Hu (Xavier) <xavier.huwei@huawei.com>\0" "Subject\0Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value\0" - "Date\0Sat, 30 Sep 2017 07:11:05 +0000\0" + "Date\0Sat, 30 Sep 2017 15:11:05 +0800\0" "To\0Colin King <colin.king@canonical.com>" Doug Ledford <dledford@redhat.com> " Sean Hefty <sean.hefty@intel.com>\0" "Cc\0Lijun Ou <oulijun@huawei.com>" Hal Rosenstock <hal.rosenstock@gmail.com> - linux-rdma@vger.kernel.org - kernel-janitors@vger.kernel.org - " linux-kernel@vger.kernel.org\0" + <linux-rdma@vger.kernel.org> + <kernel-janitors@vger.kernel.org> + " <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" "Thanks, Colin Ian King\n" @@ -19,7 +19,7 @@ "On 2017/9/30 4:13, Colin King wrote:\n" "> From: Colin Ian King <colin.king@canonical.com>\n" ">\n" - "> For the case where hr_qp->state = IB_QPS_RESET, an uninitialized\n" + "> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized\n" "> value in ret is being returned by function hns_roce_v2_query_qp.\n" "> Fix this by setting ret to 0 for this specific return condition.\n" ">\n" @@ -36,11 +36,11 @@ "> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c\n" "> @@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,\n" "> \n" - "> \tif (hr_qp->state = IB_QPS_RESET) {\n" + "> \tif (hr_qp->state == IB_QPS_RESET) {\n" "> \t\tqp_attr->qp_state = IB_QPS_RESET;\n" "> +\t\tret = 0;\n" "> \t\tgoto done;\n" "> \t}\n" > -2c84b7ffeaec038e2e752115e2ce9e579497fb8d0daa213b4ddbdc511b15115c +40f5a778b067b6cf9a5a6388a2937f4461dee202824ec97db90b269516b069f3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.