From: Daniel Borkmann <daniel@iogearbox.net>
To: Craig Gallek <kraigatgoog@gmail.com>,
Alexei Starovoitov <ast@fb.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
"David S . Miller" <davem@davemloft.net>
Cc: Chonggang Li <chonggangli@google.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] libbpf: parse maps sections of varying size
Date: Thu, 05 Oct 2017 21:25:49 +0200 [thread overview]
Message-ID: <59D6873D.6070407@iogearbox.net> (raw)
In-Reply-To: <20171005144158.14860-2-kraigatgoog@gmail.com>
On 10/05/2017 04:41 PM, Craig Gallek wrote:
> From: Craig Gallek <kraig@google.com>
>
> This library previously assumed a fixed-size map options structure.
> Any new options were ignored. In order to allow the options structure
> to grow and to support parsing older programs, this patch updates
> the maps section parsing to handle varying sizes.
>
> Object files with maps sections smaller than expected will have the new
> fields initialized to zero. Object files which have larger than expected
> maps sections will be rejected unless all of the unrecognized data is zero.
>
> This change still assumes that each map definition in the maps section
> is the same size.
>
> Signed-off-by: Craig Gallek <kraig@google.com>
Thanks,
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-10-05 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 14:41 [PATCH net-next v3 0/2] libbpf: support more map options Craig Gallek
2017-10-05 14:41 ` [PATCH net-next v3 1/2] libbpf: parse maps sections of varying size Craig Gallek
2017-10-05 17:52 ` Jesper Dangaard Brouer
2017-10-05 19:25 ` Daniel Borkmann [this message]
2017-10-05 14:41 ` [PATCH net-next v3 2/2] libbpf: use map_flags when creating maps Craig Gallek
2017-10-05 19:26 ` Daniel Borkmann
2017-10-05 16:17 ` [PATCH net-next v3 0/2] libbpf: support more map options Alexei Starovoitov
2017-10-06 4:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59D6873D.6070407@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=brouer@redhat.com \
--cc=chonggangli@google.com \
--cc=davem@davemloft.net \
--cc=kraigatgoog@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.