From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752399AbdJFRVu (ORCPT ); Fri, 6 Oct 2017 13:21:50 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:37185 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbdJFRVt (ORCPT ); Fri, 6 Oct 2017 13:21:49 -0400 X-Google-Smtp-Source: AOwi7QDYlOFSGAmdrqORPjVTr+TXabkb3vFlHNV+7ASxWWM34+8IkuAtljyW5+qdeqTccSvXfReGGg== Subject: Re: [PATCH] staging: comedi: dt282x: release irq on dt282x detach To: abbotti@mev.co.uk, hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <748fce08720473cd8124b10690cf4661688bb925.1507307537.git.arvind.yadav.cs@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: arvindY Message-ID: <59D7BBA9.4040904@gmail.com> Date: Fri, 6 Oct 2017 22:51:45 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <748fce08720473cd8124b10690cf4661688bb925.1507307537.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry for noise, ignore this patch. On Friday 06 October 2017 10:06 PM, Arvind Yadav wrote: > free_irq() should be called on driver 'dt282x' detach. > > Signed-off-by: Arvind Yadav > --- > drivers/staging/comedi/drivers/dt282x.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/staging/comedi/drivers/dt282x.c > index d5295bb..a132f60 100644 > --- a/drivers/staging/comedi/drivers/dt282x.c > +++ b/drivers/staging/comedi/drivers/dt282x.c > @@ -1057,6 +1057,8 @@ static void dt282x_alloc_dma(struct comedi_device *dev, > if (request_irq(irq_num, dt282x_interrupt, 0, dev->board_name, dev)) > return; > > + dev->irq = irq_num; > + > /* DMA uses two 4K buffers with separate DMA channels */ > devpriv->dma = comedi_isadma_alloc(dev, 2, dma_chan[0], dma_chan[1], > PAGE_SIZE, 0); > @@ -1070,6 +1072,9 @@ static void dt282x_free_dma(struct comedi_device *dev) > > if (devpriv) > comedi_isadma_free(devpriv->dma); > + > + if (dev->irq) > + free_irq(dev->irq, dev); > } > > static int dt282x_initialize(struct comedi_device *dev)