From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] kbuild: comments cleanup in Makefile.lib
Date: Mon, 9 Oct 2017 11:43:07 +0800 [thread overview]
Message-ID: <59DAF04B.2050601@cn.fujitsu.com> (raw)
In-Reply-To: <CAK7LNASc52YJKyowkgy9=82L-SQc3TKUmhaapNcRFoXx81umcA@mail.gmail.com>
Masahiro-san,
On 10/04/2017 12:58 PM, Masahiro Yamada wrote:
> Hi Cao,
>
>
> 2017-09-19 20:36 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
>> It has:
>> 1. Move comments close to what it want to comment.
>> 2. Comments cleanup & improvement.
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>>
>> -# if $(foo-objs) exists, foo.o is a composite object
>> +# if $(foo-objs) or $(foo-y) or $(foo-m) exists, foo.o is a composite object
>
>
> Nit:
>
> "if $(foo-objs), $(foo-y), or $(foo-m) exists" will be better.
>
Yes, true.
>> multi-used-y := $(sort $(foreach m,$(obj-y), $(if $(strip $($(m:.o=-objs)) $($(m:.o=-y))), $(m))))
>> multi-used-m := $(sort $(foreach m,$(obj-m), $(if $(strip $($(m:.o=-objs)) $($(m:.o=-y)) $($(m:.o=-m))), $(m))))
>> multi-used := $(multi-used-y) $(multi-used-m)
>> @@ -90,7 +84,6 @@ subdir-ym := $(addprefix $(obj)/,$(subdir-ym))
>> obj-dirs := $(addprefix $(obj)/,$(obj-dirs))
>>
>> # These flags are needed for modversions and compiling, so we define them here
>> -# already
>> # $(modname_flags) #defines KBUILD_MODNAME as the name of the module it will
>
>
> I am not sure if "#defines" is intentional or not.
> I think "#" is unnecessary.
>
Yes, agree with you
--
Sincerely,
Cao jin
next prev parent reply other threads:[~2017-10-09 3:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 11:36 [PATCH] kbuild: comments cleanup in Makefile.lib Cao jin
2017-09-19 11:36 ` Cao jin
2017-10-04 4:58 ` Masahiro Yamada
2017-10-09 3:43 ` Cao jin [this message]
2017-10-10 11:44 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59DAF04B.2050601@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.