From mboxrd@z Thu Jan 1 00:00:00 1970 From: james.morse@arm.com (James Morse) Date: Wed, 11 Oct 2017 16:34:45 +0100 Subject: [PATCH 1/3] arm: vdso: Rewrite gettimeofday to more closely match arm64 variant In-Reply-To: <20170911161827.112786-1-salyzyn@android.com> References: <20170911161827.112786-1-salyzyn@android.com> Message-ID: <59DE3A15.90800@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 11/09/17 17:18, Mark Salyzyn wrote: > Take an effort to recode the arm64 vdso code from assembler to C > previously submitted by Andrew Pinski , rework > it for use in both arm and arm64, overlapping any optimizations > for each architecture. > > Side effects include renaming some vdso_datapage.h variables, adding > a few more to enhance features and functionality to match. There are quite a lot of different things going on here, all of which are interleaved in this patch. Could you split them out into smaller simpler changes? The bits I count are: * Pulling 32bit specific eabi and fallback macro out into compiler.h, * Adding support for __vdso_clock_getres, * Flipping tk_is_cntvct's logic to become use_syscall, * Variable renames to align 32/64 bit, ...are those 'coarse' versions of the timer calls being added, or just moved around? Thanks, James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbdJKPg0 (ORCPT ); Wed, 11 Oct 2017 11:36:26 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:34792 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbdJKPgZ (ORCPT ); Wed, 11 Oct 2017 11:36:25 -0400 Message-ID: <59DE3A15.90800@arm.com> Date: Wed, 11 Oct 2017 16:34:45 +0100 From: James Morse User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Mark Salyzyn CC: linux-kernel@vger.kernel.org, kevin.brodsky@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, mingo@kernel.org, borntraeger@de.ibm.com, peterz@infradead.org, Dave.Martin@arm.com, credmonster@gmail.com, zijun_hu@htc.com, mark.rutland@arm.com, jszhang@marvell.com, labbott@redhat.com, john.stultz@linaro.org, keescook@chromium.org, linux-arm-kernel@lists.infradead.org, takahiro.akashi@linaro.org, mmarek@suse.com, ard.biesheuvel@linaro.org, Russell King , Mark Salyzyn , Andy Lutomirski , Scott Wood , Dmitry Safonov Subject: Re: [PATCH 1/3] arm: vdso: Rewrite gettimeofday to more closely match arm64 variant References: <20170911161827.112786-1-salyzyn@android.com> In-Reply-To: <20170911161827.112786-1-salyzyn@android.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 11/09/17 17:18, Mark Salyzyn wrote: > Take an effort to recode the arm64 vdso code from assembler to C > previously submitted by Andrew Pinski , rework > it for use in both arm and arm64, overlapping any optimizations > for each architecture. > > Side effects include renaming some vdso_datapage.h variables, adding > a few more to enhance features and functionality to match. There are quite a lot of different things going on here, all of which are interleaved in this patch. Could you split them out into smaller simpler changes? The bits I count are: * Pulling 32bit specific eabi and fallback macro out into compiler.h, * Adding support for __vdso_clock_getres, * Flipping tk_is_cntvct's logic to become use_syscall, * Variable renames to align 32/64 bit, ...are those 'coarse' versions of the timer calls being added, or just moved around? Thanks, James