From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks Date: Fri, 13 Oct 2017 18:47:18 +0800 Message-ID: <59E099B6.1000804@rock-chips.com> References: <20171013100116.8271-1-jeffy.chen@rock-chips.com> <20171013101719.bophbiz7qb5wi7n2@sirena.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171013101719.bophbiz7qb5wi7n2-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Heiko Stuebner , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Hi Mark, On 10/13/2017 06:17 PM, Mark Brown wrote: > On Fri, Oct 13, 2017 at 06:01:15PM +0800, Jeffy Chen wrote: >> Currently we are suspending the spi master in it's ->suspend callback, >> which is racy as some other drivers may still want to transmit messages >> on the bus(e.g. spi based pwm backlight). > > I'm missing patch 2/2. > Sorry, i'll resend them... This patch is to defer suspend_spi_master to late suspend. Since we put display-subsystem dt node above spi dt node, which makes spi suspend been called before display driver. Then the display driver would fail to set pwm backlight through spi in it's suspend/resume. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (jeffy) Date: Fri, 13 Oct 2017 18:47:18 +0800 Subject: [PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks In-Reply-To: <20171013101719.bophbiz7qb5wi7n2@sirena.co.uk> References: <20171013100116.8271-1-jeffy.chen@rock-chips.com> <20171013101719.bophbiz7qb5wi7n2@sirena.co.uk> Message-ID: <59E099B6.1000804@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 10/13/2017 06:17 PM, Mark Brown wrote: > On Fri, Oct 13, 2017 at 06:01:15PM +0800, Jeffy Chen wrote: >> Currently we are suspending the spi master in it's ->suspend callback, >> which is racy as some other drivers may still want to transmit messages >> on the bus(e.g. spi based pwm backlight). > > I'm missing patch 2/2. > Sorry, i'll resend them... This patch is to defer suspend_spi_master to late suspend. Since we put display-subsystem dt node above spi dt node, which makes spi suspend been called before display driver. Then the display driver would fail to set pwm backlight through spi in it's suspend/resume. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757807AbdJMKr0 (ORCPT ); Fri, 13 Oct 2017 06:47:26 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:35786 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753231AbdJMKrZ (ORCPT ); Fri, 13 Oct 2017 06:47:25 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: broonie@kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59E099B6.1000804@rock-chips.com> Date: Fri, 13 Oct 2017 18:47:18 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Mark Brown CC: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, Heiko Stuebner , linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks References: <20171013100116.8271-1-jeffy.chen@rock-chips.com> <20171013101719.bophbiz7qb5wi7n2@sirena.co.uk> In-Reply-To: <20171013101719.bophbiz7qb5wi7n2@sirena.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 10/13/2017 06:17 PM, Mark Brown wrote: > On Fri, Oct 13, 2017 at 06:01:15PM +0800, Jeffy Chen wrote: >> Currently we are suspending the spi master in it's ->suspend callback, >> which is racy as some other drivers may still want to transmit messages >> on the bus(e.g. spi based pwm backlight). > > I'm missing patch 2/2. > Sorry, i'll resend them... This patch is to defer suspend_spi_master to late suspend. Since we put display-subsystem dt node above spi dt node, which makes spi suspend been called before display driver. Then the display driver would fail to set pwm backlight through spi in it's suspend/resume.