From: Frank Rowand <frowand.list@gmail.com>
To: Stephen Boyd <stephen.boyd@linaro.org>, Rob Herring <robh+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] of: unittest: Remove redundant OF_DETACHED flag setting
Date: Fri, 13 Oct 2017 15:12:15 -0700 [thread overview]
Message-ID: <59E13A3F.5070509@gmail.com> (raw)
In-Reply-To: <20171013074451.14176-1-stephen.boyd@linaro.org>
On 10/13/17 00:44, Stephen Boyd wrote:
> of_fdt_unflatten_tree() already sets the flag on the node to
> OF_DETACHED, because of_fdt_unflatten_tree() calls
> __unflatten_device_tree() with the detached bool set to true.
>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
> drivers/of/unittest.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 35bf9617ae59..8795478a4754 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -1112,7 +1112,6 @@ static int __init unittest_data_add(void)
> pr_warn("%s: No tree to attach; not running tests\n", __func__);
> return -ENODATA;
> }
> - of_node_set_flag(unittest_data_node, OF_DETACHED);
> rc = of_resolve_phandles(unittest_data_node);
> if (rc) {
> pr_err("%s: Failed to resolve phandles (rc=%i)\n", __func__, rc);
> @@ -2262,7 +2261,6 @@ static int __init overlay_data_add(int onum)
> ret = 0;
> goto out_free_data;
> }
> - of_node_set_flag(info->np_overlay, OF_DETACHED);
>
> ret = of_resolve_phandles(info->np_overlay);
> if (ret) {
>
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
Should be no conflict with my patch series "[PATCH 00/12] of: overlay: clean up
device tree overlay code" [1], just a line offset.
[1] https://lkml.org/lkml/2017/10/2/679
next prev parent reply other threads:[~2017-10-13 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 7:44 [PATCH] of: unittest: Remove redundant OF_DETACHED flag setting Stephen Boyd
2017-10-13 7:44 ` Stephen Boyd
2017-10-13 22:12 ` Frank Rowand [this message]
[not found] ` <20171013074451.14176-1-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-10-16 21:50 ` Rob Herring
2017-10-16 21:50 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59E13A3F.5070509@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.