All of lore.kernel.org
 help / color / mirror / Atom feed
From: jeffy <jeffy.chen@rock-chips.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
	heiko@sntech.de, briannorris@chromium.org, rjw@rjwysocki.net,
	dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org,
	seanpaul@chromium.org, thierry.reding@gmail.com
Subject: Re: [PATCH] driver core: Make sure device detached from driver before deleting it
Date: Wed, 18 Oct 2017 15:06:54 +0800	[thread overview]
Message-ID: <59E6FD8E.5040805@rock-chips.com> (raw)
In-Reply-To: <20171018061952.GA18857@kroah.com>

Hi Greg,

Thanks for your reply.

On 10/18/2017 02:19 PM, Greg Kroah-Hartman wrote:
> On Wed, Oct 18, 2017 at 01:49:26PM +0800, Jeffy Chen wrote:
>> >There are cases we call device_del() without detaching it from the
>> >driver(e.g. spi core del children devices).
> Why would you do that?  Shouldn't that be fixed instead of this odd
> work-around for a broken bus?
>
i was thinking since the device_unregister() is called everywhere, maybe 
there are some other drivers missing that too?

and the driver calls device_add(), then the core attaches the device to 
the driver automatically, maybe it would make sense to let the core 
automatic detach it somehow...

but i know nothing about driver core, maybe i should fix it in spi core, 
i'll send new patch for that :)

> thanks,
>
> greg k-h
>
>
>

  reply	other threads:[~2017-10-18  7:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18  5:49 [PATCH] driver core: Make sure device detached from driver before deleting it Jeffy Chen
2017-10-18  6:19 ` Greg Kroah-Hartman
2017-10-18  7:06   ` jeffy [this message]
2017-10-18  7:33     ` Greg Kroah-Hartman
2017-10-18  8:32       ` jeffy
2017-10-18  9:47   ` Mark Brown
2017-10-18 10:01     ` Rafael J. Wysocki
2017-10-18 10:04 ` Rafael J. Wysocki
2017-10-18 11:11   ` jeffy
2017-10-18 11:32     ` jeffy
2017-10-18 11:32       ` Rafael J. Wysocki
2017-10-18 11:33       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59E6FD8E.5040805@rock-chips.com \
    --to=jeffy.chen@rock-chips.com \
    --cc=briannorris@chromium.org \
    --cc=broonie@kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=seanpaul@chromium.org \
    --cc=tfiga@chromium.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.