From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v3 10/14] extcon: intel-int3496: Add support for controlling the USB-role mux Date: Wed, 18 Oct 2017 18:40:07 +0900 Message-ID: <59E72177.8000603@samsung.com> References: <20170922183803.10701-1-hdegoede@redhat.com> <20170922183803.10701-10-hdegoede@redhat.com> <59E6BD6A.4020101@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org To: Hans de Goede , MyungJoo Ham , Guenter Roeck , Heikki Krogerus , Darren Hart , Andy Shevchenko , Peter Rosin , Mathias Nyman Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org, Kuppuswamy Sathyanarayanan , Sathyanarayanan Kuppuswamy Natarajan , Greg Kroah-Hartman , linux-usb@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On 2017년 10월 18일 18:14, Hans de Goede wrote: > Hi, > > On 18-10-17 04:33, Chanwoo Choi wrote: >> Hi Hans, >> >> On 2017년 09월 23일 03:37, Hans de Goede wrote: >>> Cherry Trail SoCs have a built-in USB-role mux for switching between >>> the host and device controllers, rather then using an external mux >>> controller by a GPIO. >>> >>> There is a driver using the mux-subsys to control this mux, this >>> commit adds support to the intel-int3496 driver to get a mux_controller >>> handle for the mux and set the mux through the mux-subsys rather then >>> through a GPIO. >>> >>> Signed-off-by: Hans de Goede >>> --- >>> Changes in v2: >>> -Drop || COMPILE_TEST from Kconfig depends on, as we will now fail to >>> compile on !X86 >>> -Minor code style tweaks >>> --- >>> drivers/extcon/Kconfig | 3 +- >>> drivers/extcon/extcon-intel-int3496.c | 59 +++++++++++++++++++++++++++++++++++ >>> 2 files changed, 61 insertions(+), 1 deletion(-) >> >> Acked-by: Chanwoo Choi > > Note that there have been some comments on this series, and it > is not sure yet how we are going to end up handling this. So > please do not merge this yet, as we may end up with another > solution. Sure. I don't merge only this patch. After finishing the review of this patchset, one maintainer apply all patches and then send immutable pull request. -- Best Regards, Chanwoo Choi Samsung Electronics