From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751724AbdJSBL4 (ORCPT ); Wed, 18 Oct 2017 21:11:56 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:44246 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbdJSBLx (ORCPT ); Wed, 18 Oct 2017 21:11:53 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: rjw@rjwysocki.net X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59E7FBCC.4070201@rock-chips.com> Date: Thu, 19 Oct 2017 09:11:40 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: linux-kernel@vger.kernel.org, seanpaul@chromium.irg, briannorris@chromium.org, heiko@sntech.de, gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com, dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org, thierry.reding@gmail.com Subject: Re: [PATCH] driver core: Move device_links_purge() after bus_remove_device() References: <20171018112839.31985-1-jeffy.chen@rock-chips.com> <2591080.ki3098E8CB@aspire.rjw.lan> In-Reply-To: <2591080.ki3098E8CB@aspire.rjw.lan> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On 10/19/2017 07:36 AM, Rafael J. Wysocki wrote: > Why don't you write something like the following: > > "The current ordering of code in device_del() triggers a WARN_ON() > in device_links_purge(), because of an unexpected link status. > > The device_links_unbind_consumers() call in device_release_driver() > has to take place before device_links_purge() for the status of all > links to be correct, so move the device_links_purge() call in > device_del() after the invocation of bus_remove_device() which calls > device_release_driver()." that looks much better, i'll use it and your signed-off, thanks :)