From: jeffy <jeffy.chen@rock-chips.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: dmitry.torokhov@gmail.com, briannorris@chromium.org,
rjw@rjwysocki.net, dianders@chromium.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, broonie@kernel.org,
tfiga@chromium.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v4 4/8] drm/rockchip: dw_hdmi: Fix error handling path
Date: Thu, 19 Oct 2017 09:54:40 +0800 [thread overview]
Message-ID: <59E805E0.50006@rock-chips.com> (raw)
In-Reply-To: <20171017181034.tsplfsmq7vi4uhmo@art_vandelay>
Hi Sean,
Thanks for your review.
On 10/18/2017 02:10 AM, Sean Paul wrote:
> On Tue, Oct 17, 2017 at 06:16:20PM +0800, Jeffy Chen wrote:
>> >Add missing clk_disable_unprepare() in bind()'s error handling path.
> This also isn't disabled in unbind(), is that intentional?
>
i wasn't able to do that because of dw_hdmi drvdata.
i've modified it as tomasz did for dp bridge, and fixed the unbind() in
the next version :)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (jeffy)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v4 4/8] drm/rockchip: dw_hdmi: Fix error handling path
Date: Thu, 19 Oct 2017 09:54:40 +0800 [thread overview]
Message-ID: <59E805E0.50006@rock-chips.com> (raw)
In-Reply-To: <20171017181034.tsplfsmq7vi4uhmo@art_vandelay>
Hi Sean,
Thanks for your review.
On 10/18/2017 02:10 AM, Sean Paul wrote:
> On Tue, Oct 17, 2017 at 06:16:20PM +0800, Jeffy Chen wrote:
>> >Add missing clk_disable_unprepare() in bind()'s error handling path.
> This also isn't disabled in unbind(), is that intentional?
>
i wasn't able to do that because of dw_hdmi drvdata.
i've modified it as tomasz did for dp bridge, and fixed the unbind() in
the next version :)
WARNING: multiple messages have this Message-ID (diff)
From: jeffy <jeffy.chen@rock-chips.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
heiko@sntech.de, briannorris@chromium.org, rjw@rjwysocki.net,
dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org,
Mark Yao <mark.yao@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
David Airlie <airlied@linux.ie>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v4 4/8] drm/rockchip: dw_hdmi: Fix error handling path
Date: Thu, 19 Oct 2017 09:54:40 +0800 [thread overview]
Message-ID: <59E805E0.50006@rock-chips.com> (raw)
In-Reply-To: <20171017181034.tsplfsmq7vi4uhmo@art_vandelay>
Hi Sean,
Thanks for your review.
On 10/18/2017 02:10 AM, Sean Paul wrote:
> On Tue, Oct 17, 2017 at 06:16:20PM +0800, Jeffy Chen wrote:
>> >Add missing clk_disable_unprepare() in bind()'s error handling path.
> This also isn't disabled in unbind(), is that intentional?
>
i wasn't able to do that because of dw_hdmi drvdata.
i've modified it as tomasz did for dp bridge, and fixed the unbind() in
the next version :)
next prev parent reply other threads:[~2017-10-19 1:54 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 10:16 [RFC PATCH v4 0/8] rockchip: kevin: Enable edp display Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` [RFC PATCH v4 1/8] arm64: dts: rockchip: Enable edp disaplay on kevin Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` [RFC PATCH v4 2/8] drm/rockchip: analogix_dp: Fix error handling path Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 17:57 ` Sean Paul
2017-10-17 17:57 ` Sean Paul
2017-10-17 17:57 ` Sean Paul
2017-10-17 10:16 ` [RFC PATCH v4 3/8] drm/rockchip: dw-mipi-dsi: " Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:02 ` Sean Paul
2017-10-17 18:02 ` Sean Paul
2017-10-17 18:02 ` Sean Paul
2017-10-17 10:16 ` [RFC PATCH v4 4/8] drm/rockchip: dw_hdmi: " Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:10 ` Sean Paul
2017-10-17 18:10 ` Sean Paul
2017-10-17 18:10 ` Sean Paul
2017-10-19 1:54 ` jeffy [this message]
2017-10-19 1:54 ` jeffy
2017-10-19 1:54 ` jeffy
2017-10-17 10:16 ` [RFC PATCH v4 5/8] drm/rockchip: inno_hdmi: " Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:18 ` Sean Paul
2017-10-17 18:18 ` Sean Paul
2017-10-17 10:16 ` [RFC PATCH v4 6/8] drm/bridge/analogix: Do not use device's drvdata Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:18 ` Sean Paul
2017-10-17 18:18 ` Sean Paul
2017-10-17 18:18 ` Sean Paul
2017-10-17 23:43 ` Jingoo Han
2017-10-17 23:43 ` Jingoo Han
2017-10-17 23:43 ` Jingoo Han
2017-10-18 4:46 ` Archit Taneja
2017-10-18 4:46 ` Archit Taneja
2017-10-18 4:46 ` Archit Taneja
2017-10-17 10:16 ` [RFC PATCH v4 7/8] pwm: Add dummy pwmchip for orphan pwms Jeffy Chen
2017-10-17 12:40 ` Thierry Reding
2017-10-17 17:04 ` Brian Norris
2017-10-17 18:24 ` Dmitry Torokhov
2017-10-17 18:46 ` Mark Brown
2017-10-17 18:53 ` Brian Norris
2017-10-17 19:05 ` Mark Brown
2017-10-18 5:16 ` jeffy
2017-10-17 10:16 ` [RFC PATCH v4 8/8] drm/rockchip: Add device links for master and components Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:24 ` Sean Paul
2017-10-17 18:24 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59E805E0.50006@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rjw@rjwysocki.net \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.