From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove Date: Thu, 19 Oct 2017 14:49:20 -0700 Message-ID: <59E91DE0.5090106@gmail.com> References: <1508447907-4462-1-git-send-email-frowand.list@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1508447907-4462-1-git-send-email-frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org, Pantelis Antoniou Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/19/17 14:18, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > From: Frank Rowand > > A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP, > or an embedded errno. overlay_notify() incorrectly reports an > error for NOTIFY_OK. > > Reported-by: atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org > Signed-off-by: Frank Rowand > --- > drivers/of/overlay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c > index c99842bb4b09..f5fce0fea40b 100644 > --- a/drivers/of/overlay.c > +++ b/drivers/of/overlay.c > @@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs, > > ret = blocking_notifier_call_chain(&overlay_notify_chain, > action, &nd); > - if (ret == NOTIFY_STOP) > + if (ret == NOTIFY_OK || ret == NOTIFY_STOP) > return 0; > if (ret) { > ret = notifier_to_errno(ret); > Not needed in any stable kernel. This is caused by "[PATCH v3 00/12] of: overlay: clean up device tree overlay code". -Frank -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011AbdJSVtY (ORCPT ); Thu, 19 Oct 2017 17:49:24 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:50762 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752050AbdJSVtW (ORCPT ); Thu, 19 Oct 2017 17:49:22 -0400 X-Google-Smtp-Source: ABhQp+RHf1WMy4ZzjvuJhcAcs8cLl9lS3uTm4PmO4+zgpPgM6E+/bEtJVO/78Z9VWnj725sU+HZwtA== Subject: Re: [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove To: Rob Herring , atull@kernel.org, pantelis.antoniou@konsulko.com, Pantelis Antoniou References: <1508447907-4462-1-git-send-email-frowand.list@gmail.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Frank Rowand Message-ID: <59E91DE0.5090106@gmail.com> Date: Thu, 19 Oct 2017 14:49:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1508447907-4462-1-git-send-email-frowand.list@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/17 14:18, frowand.list@gmail.com wrote: > From: Frank Rowand > > A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP, > or an embedded errno. overlay_notify() incorrectly reports an > error for NOTIFY_OK. > > Reported-by: atull@kernel.org > Signed-off-by: Frank Rowand > --- > drivers/of/overlay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c > index c99842bb4b09..f5fce0fea40b 100644 > --- a/drivers/of/overlay.c > +++ b/drivers/of/overlay.c > @@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs, > > ret = blocking_notifier_call_chain(&overlay_notify_chain, > action, &nd); > - if (ret == NOTIFY_STOP) > + if (ret == NOTIFY_OK || ret == NOTIFY_STOP) > return 0; > if (ret) { > ret = notifier_to_errno(ret); > Not needed in any stable kernel. This is caused by "[PATCH v3 00/12] of: overlay: clean up device tree overlay code". -Frank