From: Daniel Borkmann <daniel@iogearbox.net>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Cc: ast@kernel.org, john.fastabend@gmail.com
Subject: Re: [MERGE README] net --> net-next
Date: Sun, 22 Oct 2017 21:41:33 +0200 [thread overview]
Message-ID: <59ECF46D.30903@iogearbox.net> (raw)
In-Reply-To: <59EC9877.6080702@iogearbox.net>
On 10/22/2017 03:09 PM, Daniel Borkmann wrote:
> On 10/22/2017 02:57 PM, David Miller wrote:
>>
>> There were quite a few BPF conflicts during the merge I just did of
>> 'net' into 'net-next'.
>>
>> In particular, all of the packet pointer branch tests in the verifier
>> had to be resolved wrt. three different sets of changes.
>>
>> The off-by-one stuff. The allowance of the 'data_end > ptr + x' form
>> of packet pointer checks. And finally, the metadata stuff.
>>
>> I would really appreciate an audit and double check of my merge work
>> by the interested parties.
>
> I will do a review today in the evening, thanks David!
Looks good overall, I notices two things (in find_good_pkt_pointers()
in the second loop the max_t(u16, ...) still exists instead of just
max() in -net and in test_verifier the test cases for 'XDP pkt read'
are split in the middle with other test cases for bpf_exit). I'll send
a cleanup on Monday for this along with the matches for metadata part.
Thanks,
Daniel
next prev parent reply other threads:[~2017-10-22 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 12:57 [MERGE README] net --> net-next David Miller
2017-10-22 13:09 ` Daniel Borkmann
2017-10-22 19:41 ` Daniel Borkmann [this message]
2017-10-23 0:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59ECF46D.30903@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.