From: Chanwoo Choi <cw00.choi@samsung.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] extcon: max14577: Delete an unnecessary variable initialisation in max14577_muic_set
Date: Mon, 23 Oct 2017 01:05:34 +0000 [thread overview]
Message-ID: <59ED405E.1030404@samsung.com> (raw)
In-Reply-To: <431ea2b6-5b03-3752-a9c1-a39b1a7e4921@users.sourceforge.net>
On 2017년 10월 23일 02:52, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 22 Oct 2017 19:39:12 +0200
>
> The variable "ret" is immediately reassigned by a following statement.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/extcon/extcon-max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index 3d4bf5d23236..a2b60742a228 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -204,8 +204,8 @@ static int max14577_muic_set_debounce_time(struct max14577_muic_info *info,
> static int max14577_muic_set_path(struct max14577_muic_info *info,
> u8 val, bool attached)
> {
> - int ret = 0;
> u8 ctrl1, ctrl2 = 0;
> + int ret;
>
> /* Set open state to path before changing hw path */
> ret = max14577_update_reg(info->max14577->regmap,
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
prev parent reply other threads:[~2017-10-23 1:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 17:52 [PATCH 2/2] extcon: max14577: Delete an unnecessary variable initialisation in max14577_muic_set_pat SF Markus Elfring
2017-10-22 19:01 ` [PATCH 2/2] extcon: max14577: Delete an unnecessary variable initialisation in max14577_muic_set Krzysztof Kozlowski
2017-10-23 1:05 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59ED405E.1030404@samsung.com \
--to=cw00.choi@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.