From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752056AbdJYGfP (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Oct 2017 02:35:15 -0400
Received: from szxga05-in.huawei.com ([45.249.212.191]:9053 "EHLO
        szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752028AbdJYGfM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Oct 2017 02:35:12 -0400
Subject: Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow
To: "Theodore Ts'o" <tytso@mit.edu>, Greg KH <gregkh@linuxfoundation.org>,
        <zhaoyukun@huawei.com>, <arnd@arndb.de>,
        <linux-kernel@vger.kernel.org>, <suzhuangluan@hisilicon.com>,
        <dan.zhao@hisilicon.com>
References: <1508831057-64195-1-git-send-email-puck.chen@hisilicon.com>
 <20171024090927.GA20625@kroah.com>
 <20171024102528.7oywdwjriesoh3mk@thunk.org>
From: Chen Feng <puck.chen@hisilicon.com>
Message-ID: <59F02FA0.7090605@hisilicon.com>
Date: Wed, 25 Oct 2017 14:30:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20171024102528.7oywdwjriesoh3mk@thunk.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.193.64]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A020205.59F02FC5.0005,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 268a9a7b23ca769d66995e2317b5ca82
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ted,

On 2017/10/24 18:25, Theodore Ts'o wrote:
> On Tue, Oct 24, 2017 at 11:09:27AM +0200, Greg KH wrote:
>> On Tue, Oct 24, 2017 at 03:44:17PM +0800, Chen Feng wrote:
>>> [pid:11940,cpu6,syz-executor][flp_ioctl]cmd[0x1]
>>> Restart is not permit
>>> =================================================================
>>> UBSAN: Undefined behaviour in
>>> kernel/linux-4.4/drivers/char/random.c:676:19
>>> signed integer overflow:
>>> 2147483645 + 268435455 cannot be represented in type 'int'
>>> CPU: 4 PID: 11941 Comm: syz-executor Not tainted 4.4.76+ #2
>>
>> Does this also happen on 4.14-rc6?
> 
> No.  It was fixed in 4.8, by commit 86a574de4590: "random: strengthen
> input validation for RNDADDTOENTCNT".


I see my kernel has already merged this patch. So I don't think this patch
can resolve the issue above.

	-feng
> 
> 						- Ted
> 
> .
>