From: Mike Christie <mchristi@redhat.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 00/20] tcmu update
Date: Sun, 29 Oct 2017 16:41:39 +0000 [thread overview]
Message-ID: <59F604C3.9050907@redhat.com> (raw)
In-Reply-To: <1508950050-10120-1-git-send-email-mchristi@redhat.com>
On 10/25/2017 11:47 AM, Mike Christie wrote:
> - Patch 5 - 18 fix bugs in tcmu's ring buffer code.
> - Patch 18 - 20 allow you to configure the size of the ring buffer
Hey Nick,
If you are out there, do not merge patches 5 - 20. I have a patchset
that will simplify things.
You should also drop
commit b8501553476c2eabbd15da79e152a84a9a67dc5a
Author: Xiubo Li <lixiubo@cmss.chinamobile.com>
Date: Wed Jul 12 15:16:07 2017 +0800
tcmu: Add fifo type waiter list support to avoid starvation
https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git/commit/?h=for-next&idị501553476c2eabbd15da79e152a84a9a67dc5a
and
commit 04229774f69250e0f7e63b4d1b50ba8371c9d165
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue Aug 1 23:09:17 2017 +0300
tcmu: Oops in unmap_thread_fn()
Calling list_del() on the iterator pointer in list_for_each_entry() will
cause an oops. We need to user the _safe() version for that.
https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git/commit/?h=for-next&id\x04229774f69250e0f7e63b4d1b50ba8371c9d165
from your for-next branch. That first patch added several regressions
and the second patch is then not needed. My new patchset will fix the
starvation issue.
prev parent reply other threads:[~2017-10-29 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 16:47 [PATCH 00/20] tcmu update Mike Christie
2017-10-29 16:41 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59F604C3.9050907@redhat.com \
--to=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.