All of lore.kernel.org
 help / color / mirror / Atom feed
From: jeffy <jeffy.chen@rock-chips.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, bhelgaas@google.com,
	linux-pm@vger.kernel.org, tony@atomide.com,
	shawn.lin@rock-chips.com, briannorris@chromium.org,
	rjw@rjwysocki.net, dianders@chromium.org,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree@vger.kernel.org
Subject: Re: [RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple interrupts
Date: Mon, 30 Oct 2017 10:05:51 +0800	[thread overview]
Message-ID: <59F688FF.9020806@rock-chips.com> (raw)
In-Reply-To: <20171027143812.5i4vathfjpgld7wk@rob-hp-laptop>

Hi Rob,

On 10/27/2017 10:38 PM, Rob Herring wrote:
>> +		prop = of_find_property(dn, "interrupt-names", NULL);
>> >+		for (name = of_prop_next_string(prop, NULL); name;
>> >+		     name = of_prop_next_string(prop, name), index++) {
>> >+			if (!strcmp(name, "pci"))
>> >+				break;
> Use of_property_match_string
>
i'm trying to find the first unnamed or "pci" named irq in the string 
array, so cannot use that API:)

but will change to of_property_for_each_string as Brian suggested.

  reply	other threads:[~2017-10-30  2:05 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 13:28 [RFC PATCH v8 0/7] PCI: rockchip: Move PCIe WAKE# handling into pci core Jeffy Chen
2017-10-26 13:28 ` Jeffy Chen
2017-10-26 13:28 ` Jeffy Chen
2017-10-26 13:28 ` Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 1/7] dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq Jeffy Chen
2017-10-27  2:33   ` Brian Norris
2017-10-27  3:06     ` jeffy
2017-10-27  5:40       ` Brian Norris
2017-10-27  5:57         ` jeffy
     [not found] ` <20171026132840.20946-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-10-26 13:28   ` [RFC PATCH v8 2/7] mwifiex: Disable wakeup irq handling for pcie Jeffy Chen
2017-10-26 13:28     ` Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 3/7] arm64: dts: rockchip: Handle PCIe WAKE# signal in pcie driver for Gru Jeffy Chen
2017-10-26 13:28   ` Jeffy Chen
2017-10-26 13:28   ` Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple interrupts Jeffy Chen
2017-10-26 20:02   ` Rob Herring
2017-10-27  2:05     ` jeffy
2017-10-27 14:38   ` Rob Herring
2017-10-30  2:05     ` jeffy [this message]
2017-10-30 18:46       ` Brian Norris
2017-10-26 13:28 ` [RFC PATCH v8 5/7] PCI: Make pci_platform_pm_ops's callbacks optional Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 6/7] PCI / PM: Move acpi wakeup code to pci core Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 7/7] PCI / PM: Add support for the PCIe WAKE# signal for OF Jeffy Chen
2017-10-26 14:42   ` Tony Lindgren
2017-10-27  7:37     ` jeffy
2017-10-26 15:16   ` Sinan Kaya
2017-10-27  2:09     ` jeffy
2017-10-28  0:04     ` Brian Norris
2017-10-28 18:01       ` Sinan Kaya
2017-10-28 20:39         ` Brian Norris
2017-10-27  5:55   ` Brian Norris
2017-10-27  7:32     ` jeffy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59F688FF.9020806@rock-chips.com \
    --to=jeffy.chen@rock-chips.com \
    --cc=bhelgaas@google.com \
    --cc=briannorris@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=robh@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.