From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Omar Sandoval <osandov@fb.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Roman Pen <roman.penyaev@profitbricks.com>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH V2 0/2] block: remove unnecessary RESTART
Date: Tue, 31 Oct 2017 19:53:03 -0600 [thread overview]
Message-ID: <59F9FE28-F31A-47FD-A3FD-90CE1DB38FB2@kernel.dk> (raw)
In-Reply-To: <20171101014611.GA8200@ming.t460p>
> On Oct 31, 2017, at 7:46 PM, Ming Lei <ming.lei@redhat.com> wrote:
>=20
>> On Tue, Oct 31, 2017 at 02:29:32PM -0600, Jens Axboe wrote:
>>> On 10/26/2017 10:43 PM, Ming Lei wrote:
>>> Hi Jens,
>>>=20
>>> The 1st patch removes the RESTART for TAG-SHARED because SCSI handles it=
>>> by itself, and not necessary to waste CPU to do the expensive RESTART.
>>> And Roman Pen reported that this RESTART cuts half of IOPS in his case.
>>>=20
>>> The 2nd patch removes the RESTART when .get_budget returns BLK_STS_RESOU=
RCE,
>>> and this RESTART is handled by SCSI's RESTART(scsi_end_request()) too.
>>=20
>> What base is this against?
>=20
> The for-next branch of your block tree:
=46rom when? Doesn=E2=80=99t apply at all today.=20
next prev parent reply other threads:[~2017-11-01 1:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 4:43 [PATCH V2 0/2] block: remove unnecessary RESTART Ming Lei
2017-10-27 4:43 ` [PATCH V2 1/2] blk-mq: don't handle TAG_SHARED in restart Ming Lei
2017-10-27 4:43 ` [PATCH V2 2/2] blk-mq: don't restart queue when .get_budget returns BLK_STS_RESOURCE Ming Lei
2017-10-27 4:53 ` [PATCH V2 0/2] block: remove unnecessary RESTART Bart Van Assche
2017-10-27 5:38 ` Ming Lei
2017-10-27 17:55 ` Roman Penyaev
2017-10-28 15:47 ` Ming Lei
2017-10-30 20:33 ` Bart Van Assche
2017-11-01 16:55 ` Roman Penyaev
2017-10-30 20:24 ` Bart Van Assche
2017-10-31 1:47 ` Ming Lei
2017-11-01 3:54 ` Bart Van Assche
2017-11-01 4:08 ` Ming Lei
2017-11-01 16:47 ` Bart Van Assche
2017-11-01 16:59 ` Ming Lei
2017-11-01 17:09 ` Bart Van Assche
2017-11-01 17:22 ` Ming Lei
2017-10-31 20:29 ` Jens Axboe
2017-11-01 1:46 ` Ming Lei
2017-11-01 1:53 ` Jens Axboe [this message]
2017-11-01 2:03 ` Ming Lei
2017-11-01 14:21 ` Jens Axboe
2017-11-02 15:57 ` Bart Van Assche
2017-11-02 23:38 ` Ming Lei
2017-11-02 23:43 ` Bart Van Assche
2017-11-02 23:48 ` Ming Lei
2017-11-02 23:54 ` Bart Van Assche
2017-11-03 0:15 ` Ming Lei
2017-11-03 0:48 ` Bart Van Assche
2017-11-03 1:16 ` Laurence Oberman
2017-11-03 2:12 ` Ming Lei
2017-11-03 2:42 ` Bart Van Assche
2017-11-03 3:50 ` Ming Lei
2017-11-03 15:23 ` Bart Van Assche
2017-11-03 15:47 ` Ming Lei
2017-11-03 15:50 ` Bart Van Assche
2017-11-03 16:13 ` Laurence Oberman
2017-11-03 16:47 ` Ming Lei
2017-11-03 17:13 ` Laurence Oberman
2017-11-04 2:11 ` Ming Lei
2017-11-03 15:18 ` Ming Lei
2017-11-03 15:43 ` Bart Van Assche
2017-11-03 15:47 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59F9FE28-F31A-47FD-A3FD-90CE1DB38FB2@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=roman.penyaev@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.