From: Daniel Borkmann <daniel@iogearbox.net>
To: Arnd Bergmann <arnd@arndb.de>, Alexei Starovoitov <ast@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Edward Cree <ecree@solarflare.com>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET
Date: Thu, 02 Nov 2017 23:32:38 +0100 [thread overview]
Message-ID: <59FB9D06.5010400@iogearbox.net> (raw)
In-Reply-To: <20171102110558.2746221-1-arnd@arndb.de>
On 11/02/2017 12:05 PM, Arnd Bergmann wrote:
> I ran into this link error with the latest net-next plus linux-next
> trees when networking is disabled:
>
> kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to `tc_cls_act_analyzer_ops'
> kernel/bpf/verifier.o:(.rodata+0x2970): undefined reference to `xdp_analyzer_ops'
>
> It seems that the code was written to deal with varying contents of
> the arrray, but the actual #ifdef was missing. Both tc_cls_act_analyzer_ops
> and xdp_analyzer_ops are defined in the core networking code, so adding
> a check for CONFIG_NET seems appropriate here, and I've verified this with
> many randconfig builds
>
> Fixes: 4f9218aaf8a4 ("bpf: move knowledge about post-translation offsets out of verifier")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-11-02 22:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:05 [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET Arnd Bergmann
2017-11-02 11:05 ` [PATCH 2/2] [net-next] bpf: fix out-of-bounds access warning in bpf_check Arnd Bergmann
2017-11-02 15:59 ` Alexei Starovoitov
2017-11-02 16:14 ` Arnd Bergmann
2017-11-02 17:58 ` Jakub Kicinski
2017-11-02 18:47 ` Alexei Starovoitov
2017-11-02 22:35 ` Daniel Borkmann
2017-11-03 5:20 ` David Miller
2017-11-02 17:55 ` [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET Jakub Kicinski
2017-11-02 18:48 ` Alexei Starovoitov
2017-11-02 22:32 ` Daniel Borkmann [this message]
2017-11-03 5:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59FB9D06.5010400@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.