From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 207A5C43219 for ; Fri, 11 Nov 2022 14:05:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F/aC34wl8ePluSxyKwey6xgUQdBVsE0yXV5dCRQYgWM=; b=nvA8+U4Oproi6m aXVelO8nnMxd5B7L0dRUFA0wl/hKAiCEO7C2DYOzZVtk6vR6j/515RTf34EWszUci9GFDsSDS+ctr RMcoqMCKKC2F1+s6yBvkiIl629deoGFHu1+N4Us7oyyYPI+i0lNEilcepryZztv5W6D9C6Qm6vOt1 4+UJurhev+C6YuHhbR10A+GY9PHPaivfD1gs7DeY9xr9kpT5yyeuN7NSFZiRVCRm2d+3xL+GU2nqa UdCVZwKP0CoQhfBkdHOKFs94HuPbB/I9tFiUoKenkBVpMB4jymh4xlYbwXk59YHHERdH9k6ThvUIE 761ZLC0e0A9vldAS2XUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otUdO-00G5T8-Ou; Fri, 11 Nov 2022 14:03:55 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otUdL-00G5Ny-Na for linux-arm-kernel@lists.infradead.org; Fri, 11 Nov 2022 14:03:53 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 57C2481F4E; Fri, 11 Nov 2022 15:03:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1668175425; bh=2dZBZ6zqQsML3E0ff3uEVmD5yykrHVefj/z0bzP6g3E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=psHsWEF4UaNp9uePfqEZjncEH/ArhBOv64t9Bmq5aoZd5RMAv2A3a0Im9M9JkXWCc nYG4Z+CgNL/zxpJlXy1MV7bMdIw1GFFitSp9TrlpBerG9Oo8ub5gGyNPPGfXVxQSvr ER7dl8muCmyUHus2Dg5Hgmx31kd91243yvxWMw9D3tGdbuWtMSaAAmbzDh5PiGTZ2j yH9pxFiNAKbqBqkMhaEVtM6xS0kKvQAW3+TBqFqqU4qZC1uWmHOYtNoQfV7cSkh+QV XFhTK0e0gTpfpZtSu7+iq98O9LGrwc7HoKOLDQ8JJ+0AmTBZPyFVGHEVs0h/Pm5HQK OYMf7UHLklvug== Message-ID: <59e12bc4-cf0e-2e52-0462-ebad15f83fc4@denx.de> Date: Fri, 11 Nov 2022 15:03:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/3] arm64: dts: imx8mm: Deduplicate PCIe clock-names property To: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Peng Fan , Richard Zhu , NXP Linux Team References: <20221102212248.138284-1-marex@denx.de> <20221111063323.GK2649582@dragon> Content-Language: en-US From: Marek Vasut In-Reply-To: <20221111063323.GK2649582@dragon> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221111_060352_207602_5CC72FEC X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/11/22 07:33, Shawn Guo wrote: > On Wed, Nov 02, 2022 at 10:22:46PM +0100, Marek Vasut wrote: >> Move the PCIe clock-names property from various DTs into SoC dtsi to >> reduce duplication. In case of a couple of boards, reorder the clock >> so they match the order in yaml DT bindings. >> >> Signed-off-by: Marek Vasut >> --- >> Cc: Fabio Estevam >> Cc: Peng Fan >> Cc: Richard Zhu >> Cc: Shawn Guo >> Cc: NXP Linux Team >> To: linux-arm-kernel@lists.infradead.org >> --- >> arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15.dtsi | 1 - >> arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts | 6 +++--- >> arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 5 ++--- >> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 + >> 15 files changed, 28 insertions(+), 40 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi >> index 03266bd90a06b..f3cb7e27799e7 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi >> @@ -241,9 +241,8 @@ &pcie0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_pcie0>; >> reset-gpio = <&gpio4 21 GPIO_ACTIVE_LOW>; >> - clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&clk IMX8MM_CLK_PCIE1_AUX>, >> - <&pcie0_refclk_gated>; >> - clock-names = "pcie", "pcie_aux", "pcie_bus"; >> + clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&pcie0_refclk_gated>, >> + <&clk IMX8MM_CLK_PCIE1_AUX>; > > I'm not fond of it. I would rather keep `clocks` and `clock-names` > appear as couple to ease the cross-checking. The downside of such mass duplication is the arbitrarily different ordering of clock/clock-names in some of those DTs, which needs to be corrected for dtbs_check validation to pass anyway. Since the clock-names are then identical across the SoC DTs, no need to duplicate that property anymore, one can simply open imx8m*.dtsi . Note that there is a V2 of this series. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel