From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60105C6FD18 for ; Wed, 29 Mar 2023 02:39:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbjC2CjD (ORCPT ); Tue, 28 Mar 2023 22:39:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229740AbjC2CjC (ORCPT ); Tue, 28 Mar 2023 22:39:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04DC2DE; Tue, 28 Mar 2023 19:38:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 78177B81E4A; Wed, 29 Mar 2023 02:38:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A0F5C433D2; Wed, 29 Mar 2023 02:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057517; bh=CBOVidRkW5/whhVrkK1w/Zq5SV9hEA/J2CTxiDVR04A=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Ic5dMoQ3vNovEGfy6hFtXDq21LbIkA3M6VegJhpXXAAxMAMEAdDII6IA5nG/AjGNt HutBlwjL20whsIjXARx6wdhi8SEPUzIqPXocugEWuCRKnSfJttqvp6L5V9dFvz3BrR 4dz4c3/QPPrKruguvQOMGAVuMtHLpWaCob4Dtx9tzuvPFOBDS7uHiXgMJxjOXOddoM n3ds0yps/sjM8OfJTW2tqRWMw9swzFon7dbqHV/UzPyj+khD7RG/WYfMs8KL9tHD/Z Gue+gROKlspi2hfsM3b9M37U/EAGuwmqHilLtE8bAJIsibpejwK0UDmEMGYQ9aHg61 mI6c5h2JZnUsA== Message-ID: <59f8786822d13088fe2b5646edef5829.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230312161512.2715500-17-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-17-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 16/30] clk: stm32mp1: Convert to platform remove callback returning void From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Alexandre Torgue , Maxime Coquelin , Michael Turquette , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:38:35 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Uwe Kleine-K=C3=B6nig (2023-03-12 09:14:58) > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- Applied to clk-next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A5A2C6FD18 for ; Wed, 29 Mar 2023 02:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a8AwSZ5EDrVKhfOJOIlssjVgnwc7P506AH3mxCVzrTA=; b=4iJVf8kGCX8S9v Clqe+PyTX7ivmA7E6HTaJ9tMqRwddcuW2+3N2NdK+hRMv7Ke0VxAiH1CicjiYUyh4zIp/8dAe8GZ5 PRk3Ukv43KWFPtN3wGfjeR3HGgeR2weFJWtI2GkzwZ0io1zE9q6AkYm2VH1Z3rzn9t5YRWizIMStZ kNj82DzHnjO2SpGBefpUMzL342gDV2BDcd9Kdu1CN8sxO4oZMDb65siQ3wLHcGSbT7X8V8d3VXHdi 1q1kaeqSFO+oNRVkOsodtkzlicuR5kHVtPOrEvYOFcsODzpy/RbKwub+4IHOmMnZfa+jKXMkBrrBi 0OWgyICUx+p+D5wzT2sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phLi7-00GMjA-2p; Wed, 29 Mar 2023 02:38:51 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phLhw-00GMg4-0d for linux-arm-kernel@lists.infradead.org; Wed, 29 Mar 2023 02:38:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9EF35B81F90; Wed, 29 Mar 2023 02:38:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A0F5C433D2; Wed, 29 Mar 2023 02:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057517; bh=CBOVidRkW5/whhVrkK1w/Zq5SV9hEA/J2CTxiDVR04A=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Ic5dMoQ3vNovEGfy6hFtXDq21LbIkA3M6VegJhpXXAAxMAMEAdDII6IA5nG/AjGNt HutBlwjL20whsIjXARx6wdhi8SEPUzIqPXocugEWuCRKnSfJttqvp6L5V9dFvz3BrR 4dz4c3/QPPrKruguvQOMGAVuMtHLpWaCob4Dtx9tzuvPFOBDS7uHiXgMJxjOXOddoM n3ds0yps/sjM8OfJTW2tqRWMw9swzFon7dbqHV/UzPyj+khD7RG/WYfMs8KL9tHD/Z Gue+gROKlspi2hfsM3b9M37U/EAGuwmqHilLtE8bAJIsibpejwK0UDmEMGYQ9aHg61 mI6c5h2JZnUsA== Message-ID: <59f8786822d13088fe2b5646edef5829.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230312161512.2715500-17-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-17-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 16/30] clk: stm32mp1: Convert to platform remove callback returning void From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Alexandre Torgue , Maxime Coquelin , Michael Turquette , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:38:35 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_193840_386046_C0081F7A X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UXVvdGluZyBVd2UgS2xlaW5lLUvDtm5pZyAoMjAyMy0wMy0xMiAwOToxNDo1OCkKPiBUaGUgLnJl bW92ZSgpIGNhbGxiYWNrIGZvciBhIHBsYXRmb3JtIGRyaXZlciByZXR1cm5zIGFuIGludCB3aGlj aCBtYWtlcwo+IG1hbnkgZHJpdmVyIGF1dGhvcnMgd3JvbmdseSBhc3N1bWUgaXQncyBwb3NzaWJs ZSB0byBkbyBlcnJvciBoYW5kbGluZyBieQo+IHJldHVybmluZyBhbiBlcnJvciBjb2RlLiBIb3dl dmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9zdGx5KSBpZ25vcmVkCj4gYW5kIHRoaXMgdHlw aWNhbGx5IHJlc3VsdHMgaW4gcmVzb3VyY2UgbGVha3MuIFRvIGltcHJvdmUgaGVyZSB0aGVyZSBp cyBhCj4gcXVlc3QgdG8gbWFrZSB0aGUgcmVtb3ZlIGNhbGxiYWNrIHJldHVybiB2b2lkLiBJbiB0 aGUgZmlyc3Qgc3RlcCBvZiB0aGlzCj4gcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0 byAucmVtb3ZlX25ldygpIHdoaWNoIGFscmVhZHkgcmV0dXJucwo+IHZvaWQuCj4gCj4gVHJpdmlh bGx5IGNvbnZlcnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhl IHJlbW92ZQo+IGNhbGxiYWNrIHRvIHRoZSB2b2lkIHJldHVybmluZyB2YXJpYW50Lgo+IAo+IFNp Z25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9u aXguZGU+Cj4gLS0tCgpBcHBsaWVkIHRvIGNsay1uZXh0CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==