Re: [PATCH] tidl-api: update to version 01.02.00

["Zhao, Yuan" <yuanzhao@ti.com>]

Answers embedded.  Will submit PATCH V2 later.  Thanks!  - Yuan

-----Original Message-----
From: Dmytriyenko, Denys 
Sent: Tuesday, December 4, 2018 11:20 AM
To: Zhao, Yuan
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH] tidl-api: update to version 01.02.00

On Thu, Nov 29, 2018 at 05:09:28PM -0600, Yuan Zhao wrote:
> - Minimized TIDL API/OpenCL dispatch overhead using multiple execution
>   contexts on devices.  Added MNIST example for demonstration.
> - Execution graph generation with timestamps.
> - Python 3 bindings for TIDL API.
> 
> Signed-off-by: Yuan Zhao <yuanzhao@ti.com>
> ---
>  meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc         | 6 +++---
>  meta-arago-extras/recipes-ti/tidl-api/tidl-api_git.bb      | 1 +
>  meta-arago-extras/recipes-ti/tidl-api/tidl-examples_git.bb | 2 ++
>  3 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc b/meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc
> index fb37a249..b3115c23 100644
> --- a/meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc
> +++ b/meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc
> @@ -1,11 +1,11 @@
> -PV = "1.1.0.1"
> +PV = "01.02.00"

Is this being embedded in the binary and you need it with leading zeros?

[Yuan] No, this one is not embedded.  I want to keep it in sync with what we use for release version in the documentation.  If leading zeros are not recommended, I can take them out.

>  INC_PR = "r0"
>  
> -LIC_FILES_CHKSUM = "file://tidl_api_manifest.html;md5=fb8d8b8edb866b0b233462139d1c3222"
> +LIC_FILES_CHKSUM = "file://license.txt;md5=e3daeabffb9fc131a73f16d16cbdb118"

Every time license file or checksum changes, it raises questions. To avoid 
such questions, please provide explanation in the commit log.

[Yuan] Okay, will add a comment in the commit log.

>  GIT_URI = "git://git.ti.com/tidl/tidl-api.git"
>  GIT_PROTOCOL = "git"
>  BRANCH = "master"
>  
>  SRC_URI = "${GIT_URI};protocol=${GIT_PROTOCOL};branch=${BRANCH}"
> -SRCREV = "7e9a3942ec38efd64d45e34c10cba2f2938f5618"
> +SRCREV = "03978a83b03d8881261222344d1a08e0f4e2bd06"
> diff --git a/meta-arago-extras/recipes-ti/tidl-api/tidl-api_git.bb b/meta-arago-extras/recipes-ti/tidl-api/tidl-api_git.bb
> index 47e98ef9..efd705af 100644
> --- a/meta-arago-extras/recipes-ti/tidl-api/tidl-api_git.bb
> +++ b/meta-arago-extras/recipes-ti/tidl-api/tidl-api_git.bb
> @@ -16,6 +16,7 @@ DEPENDS = "opencv \
>             opencl-monitor \
>             ti-cgt6x-native \
>             clocl-native \
> +           python3 \

You probably want to inherit python3native and/or (R)DEPENDS on python3-core 
instead of python3 here.

[Yuan]  Okay.  Will give it a try.


>  "
>  
>  RDEPENDS_${PN} += "opencl-runtime \
> diff --git a/meta-arago-extras/recipes-ti/tidl-api/tidl-examples_git.bb b/meta-arago-extras/recipes-ti/tidl-api/tidl-examples_git.bb
> index 94f215c3..2f5ca537 100644
> --- a/meta-arago-extras/recipes-ti/tidl-api/tidl-examples_git.bb
> +++ b/meta-arago-extras/recipes-ti/tidl-api/tidl-examples_git.bb
> @@ -15,11 +15,13 @@ DEPENDS = "opencv \
>             clocl-native \
>             ti-cgt6x-native \
>             tidl-api \
> +           json-c \
>  "
>  
>  RDEPENDS_${PN} += "tidl-api \
>                     opencl-runtime \
>                     opencv \
> +                   json-c \
>  "
>  
>  S = "${WORKDIR}/git"
> -- 
> 2.14.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago