From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35677D149DB for ; Fri, 25 Oct 2024 18:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RHft2vxK0Gr7puXDMf+F1Bl5xRdsOWoGQCAfyvEiVrM=; b=vKIX6Z2QzTPsIG sil3O+Hu2NcnO2TCq37Xc6z1CWUeAi3GbvnHwfHZ/K41qsqwZMpolCPDMsIh2NAvDJzi0xqQZvV/f dVlWql/YBy68fBb1FkUYvJxPzMa31tp/FeYg7hAsqXO9ybN7OQhfuiX64jzkmqj/bzSddvhCAGP5p +nxMH1id58J9oyKSWpfV5RiNbg16DYuZb5cGJCQKvR4uC50RnAiJidJr1tu8sfF9nnceQrd2q9udT fYrcLjpmoHaNJ1VTokNmredZJ8Z6BtjN73CRBqgL9ZGMAkOq7INhyZFF4UMTFFbWjsi0foaYA7aYm 7lG05JBcc+kNlYtoUXwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t4OzN-00000004mz5-3l8f; Fri, 25 Oct 2024 18:24:45 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t4OEi-00000004dDp-0IQi for linux-rockchip@lists.infradead.org; Fri, 25 Oct 2024 17:36:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1729877789; bh=x4jpxHklaZinyrxH+w/otUFIrF7xpzlfk3/g5e1I3KE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=RhWrmVOGzNQoNyvObXXer83FMP3ggDqn1HjeCx6WApTvtxLFVPvhMvbyP/Vdn+fQV SqTu2IzyAQB/jetcHZ0JArXoZmd4xdpSi96B53TpGq86qx3jOWqtmQAtasSvO2qxuQ 0Jmry+kTcmHcVh2NRAIkcDDIbu3cvh39CvB2+xEHfOYO6s9AYdz8El+cXYrrCn7kZz OWl5mfnYC+leB2tT3K+/RVCTb/xEZJuaz9+9ahafQ6UNAzNIdHNXotwSK8OdwLtxt+ qMwEugKqS/vlQmP9qOfx9C3zvcXcG8zdMtwr+qUYenBG+OrAToDRRNVyZ0bfh/ZGsk Pc65nNhGOGT5Q== Received: from nicolas-tpx395.lan (unknown [IPv6:2606:6d00:15:862e::7a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2450517E36AE; Fri, 25 Oct 2024 19:36:28 +0200 (CEST) Message-ID: <59ffa319a35e9e914bb5c8169df782ddabbd68c3.camel@collabora.com> Subject: Re: [PATCH v6 08/11] media: rkvdec: Add image format concept From: Nicolas Dufresne To: Jonas Karlman , Sebastian Fricke , Ezequiel Garcia , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Alex Bee , Benjamin Gaignard , Detlev Casanova , Dan Carpenter , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Christopher Obbard Date: Fri, 25 Oct 2024 13:36:27 -0400 In-Reply-To: <20240909192522.1076704-9-jonas@kwiboo.se> References: <20240909192522.1076704-1-jonas@kwiboo.se> <20240909192522.1076704-9-jonas@kwiboo.se> Organization: Collabora User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241025_103632_334665_6602663C X-CRM114-Status: GOOD ( 22.97 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org TGUgbHVuZGkgMDkgc2VwdGVtYnJlIDIwMjQgw6AgMTk6MjUgKzAwMDAsIEpvbmFzIEthcmxtYW4g YSDDqWNyaXTCoDoKPiBBZGQgYW4gZW51bSBya3ZkZWNfaW1hZ2VfZm10IHVzZWQgdG8gc2lnbmFs IGFuIGltYWdlIGZvcm1hdCwgZS5nLgo+IDQ6MjowIDgtYml0LCA0OjI6MCAxMC1iaXQgb3IgYW55 Lgo+IAo+IFRhZyBlYWNoIHN1cHBvcnRlZCBDQVBVVFJFIGZvcm1hdCB3aXRoIGFuIGltYWdlIGZv cm1hdCBhbmQgdXNlIHRoaXMgdGFnCj4gdG8gZmlsdGVyIG91dCB1bnN1cHBvcnRlZCBDQVBUVVJF IGZvcm1hdHMuCj4gCj4gU2lnbmVkLW9mZi1ieTogSm9uYXMgS2FybG1hbiA8am9uYXNAa3dpYm9v LnNlPgo+IFRlc3RlZC1ieTogTmljb2xhcyBEdWZyZXNuZSA8bmljb2xhcy5kdWZyZXNuZUBjb2xs YWJvcmEuY29tPgo+IFRlc3RlZC1ieTogQ2hyaXN0b3BoZXIgT2JiYXJkIDxjaHJpcy5vYmJhcmRA Y29sbGFib3JhLmNvbT4KPiAtLS0KPiB2NjoKPiAtIENoYW5nZSB0byB1c2UgZm10X2lkeCBpbnN0 ZWFkIG9mIGorKyB0dWNrZWQgaW5zaWRlIGEgY29uZGl0aW9uIChEYW4pCj4gCj4gdjU6Cj4gLSBD b2xsZWN0IHQtYiB0YWdzCj4gCj4gdjQ6Cj4gLSBDaGFuZ2UgZm10X29wYXF1ZSBpbnRvIGFuIGlt YWdlIGZvcm1hdAo+IC0gU3BsaXQgcGF0Y2ggaW50byB0d28KPiAKPiB2MzoKPiAtIE5ldyBwYXRj aAo+IC0tLQo+ICBkcml2ZXJzL3N0YWdpbmcvbWVkaWEvcmt2ZGVjL3JrdmRlYy5jIHwgNDggKysr KysrKysrKysrKysrKysrKystLS0tLS0tCj4gIGRyaXZlcnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMv cmt2ZGVjLmggfCAxMyArKysrKysrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMo KyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvbWVk aWEvcmt2ZGVjL3JrdmRlYy5jIGIvZHJpdmVycy9zdGFnaW5nL21lZGlhL3JrdmRlYy9ya3ZkZWMu Ywo+IGluZGV4IGVmYmY5YWE1NzhhZS4uNDY3ZmMwNWIzNDdhIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMvcmt2ZGVjLmMKPiArKysgYi9kcml2ZXJzL3N0YWdpbmcv bWVkaWEvcmt2ZGVjL3JrdmRlYy5jCj4gQEAgLTI3LDI2ICsyNyw0NSBAQAo+ICAjaW5jbHVkZSAi cmt2ZGVjLmgiCj4gICNpbmNsdWRlICJya3ZkZWMtcmVncy5oIgo+ICAKPiAtc3RhdGljIHUzMiBy a3ZkZWNfZW51bV9kZWNvZGVkX2ZtdChzdHJ1Y3Qgcmt2ZGVjX2N0eCAqY3R4LCBpbnQgaW5kZXgp Cj4gK3N0YXRpYyBpbmxpbmUgYm9vbCBya3ZkZWNfaW1hZ2VfZm10X21hdGNoKGVudW0gcmt2ZGVj X2ltYWdlX2ZtdCBmbXQxLAo+ICsJCQkJCSAgZW51bSBya3ZkZWNfaW1hZ2VfZm10IGZtdDIpCgpu aXQ6IFdlIHVzdWFsbHkgbGV0IHRoZSBjb21waWxlciBpbmxpbmUgZnVuY3Rpb24sIHNwZWNpYWxs eSB3aGVuIHNtYWxsIGFuZApzdGF0aWMuCgpSZXZpZXdlZC1ieTogTmljb2xhcyBEdWZyZXNuZSA8 bmljb2xhcy5kdWZyZXNuZUBjb2xsYWJvcmEuY29tPgoKPiArewo+ICsJcmV0dXJuIGZtdDEgPT0g Zm10MiB8fCBmbXQyID09IFJLVkRFQ19JTUdfRk1UX0FOWSB8fAo+ICsJICAgICAgIGZtdDEgPT0g UktWREVDX0lNR19GTVRfQU5ZOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdTMyIHJrdmRlY19lbnVtX2Rl Y29kZWRfZm10KHN0cnVjdCBya3ZkZWNfY3R4ICpjdHgsIGludCBpbmRleCwKPiArCQkJCSAgIGVu dW0gcmt2ZGVjX2ltYWdlX2ZtdCBpbWFnZV9mbXQpCj4gIHsKPiAgCWNvbnN0IHN0cnVjdCBya3Zk ZWNfY29kZWRfZm10X2Rlc2MgKmRlc2MgPSBjdHgtPmNvZGVkX2ZtdF9kZXNjOwo+ICsJaW50IGZt dF9pZHggPSAtMTsKPiArCXVuc2lnbmVkIGludCBpOwo+ICAKPiAgCWlmIChXQVJOX09OKCFkZXNj KSkKPiAgCQlyZXR1cm4gMDsKPiAgCj4gLQlpZiAoaW5kZXggPj0gZGVzYy0+bnVtX2RlY29kZWRf Zm10cykKPiAtCQlyZXR1cm4gMDsKPiArCWZvciAoaSA9IDA7IGkgPCBkZXNjLT5udW1fZGVjb2Rl ZF9mbXRzOyBpKyspIHsKPiArCQlpZiAoIXJrdmRlY19pbWFnZV9mbXRfbWF0Y2goZGVzYy0+ZGVj b2RlZF9mbXRzW2ldLmltYWdlX2ZtdCwKPiArCQkJCQkgICAgaW1hZ2VfZm10KSkKPiArCQkJY29u dGludWU7Cj4gKwkJZm10X2lkeCsrOwo+ICsJCWlmIChpbmRleCA9PSBmbXRfaWR4KQo+ICsJCQly ZXR1cm4gZGVzYy0+ZGVjb2RlZF9mbXRzW2ldLmZvdXJjYzsKPiArCX0KPiAgCj4gLQlyZXR1cm4g ZGVzYy0+ZGVjb2RlZF9mbXRzW2luZGV4XTsKPiArCXJldHVybiAwOwo+ICB9Cj4gIAo+IC1zdGF0 aWMgYm9vbCBya3ZkZWNfaXNfdmFsaWRfZm10KHN0cnVjdCBya3ZkZWNfY3R4ICpjdHgsIHUzMiBm b3VyY2MpCj4gK3N0YXRpYyBib29sIHJrdmRlY19pc192YWxpZF9mbXQoc3RydWN0IHJrdmRlY19j dHggKmN0eCwgdTMyIGZvdXJjYywKPiArCQkJCWVudW0gcmt2ZGVjX2ltYWdlX2ZtdCBpbWFnZV9m bXQpCj4gIHsKPiAgCWNvbnN0IHN0cnVjdCBya3ZkZWNfY29kZWRfZm10X2Rlc2MgKmRlc2MgPSBj dHgtPmNvZGVkX2ZtdF9kZXNjOwo+ICAJdW5zaWduZWQgaW50IGk7Cj4gIAo+ICAJZm9yIChpID0g MDsgaSA8IGRlc2MtPm51bV9kZWNvZGVkX2ZtdHM7IGkrKykgewo+IC0JCWlmIChkZXNjLT5kZWNv ZGVkX2ZtdHNbaV0gPT0gZm91cmNjKQo+ICsJCWlmIChya3ZkZWNfaW1hZ2VfZm10X21hdGNoKGRl c2MtPmRlY29kZWRfZm10c1tpXS5pbWFnZV9mbXQsCj4gKwkJCQkJICAgaW1hZ2VfZm10KSAmJgo+ ICsJCSAgICBkZXNjLT5kZWNvZGVkX2ZtdHNbaV0uZm91cmNjID09IGZvdXJjYykKPiAgCQkJcmV0 dXJuIHRydWU7Cj4gIAl9Cj4gIAo+IEBAIC04MCw3ICs5OSw3IEBAIHN0YXRpYyB2b2lkIHJrdmRl Y19yZXNldF9kZWNvZGVkX2ZtdChzdHJ1Y3Qgcmt2ZGVjX2N0eCAqY3R4KQo+ICAJc3RydWN0IHY0 bDJfZm9ybWF0ICpmID0gJmN0eC0+ZGVjb2RlZF9mbXQ7Cj4gIAl1MzIgZm91cmNjOwo+ICAKPiAt CWZvdXJjYyA9IHJrdmRlY19lbnVtX2RlY29kZWRfZm10KGN0eCwgMCk7Cj4gKwlmb3VyY2MgPSBy a3ZkZWNfZW51bV9kZWNvZGVkX2ZtdChjdHgsIDAsIGN0eC0+aW1hZ2VfZm10KTsKPiAgCXJrdmRl Y19yZXNldF9mbXQoY3R4LCBmLCBmb3VyY2MpOwo+ICAJZi0+dHlwZSA9IFY0TDJfQlVGX1RZUEVf VklERU9fQ0FQVFVSRV9NUExBTkU7Cj4gIAlmLT5mbXQucGl4X21wLndpZHRoID0gY3R4LT5jb2Rl ZF9mbXQuZm10LnBpeF9tcC53aWR0aDsKPiBAQCAtMTQ5LDggKzE2OCwxMSBAQCBzdGF0aWMgY29u c3Qgc3RydWN0IHJrdmRlY19jdHJscyBya3ZkZWNfaDI2NF9jdHJscyA9IHsKPiAgCS5udW1fY3Ry bHMgPSBBUlJBWV9TSVpFKHJrdmRlY19oMjY0X2N0cmxfZGVzY3MpLAo+ICB9Owo+ICAKPiAtc3Rh dGljIGNvbnN0IHUzMiBya3ZkZWNfaDI2NF92cDlfZGVjb2RlZF9mbXRzW10gPSB7Cj4gLQlWNEwy X1BJWF9GTVRfTlYxMiwKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBya3ZkZWNfZGVjb2RlZF9mbXRf ZGVzYyBya3ZkZWNfaDI2NF92cDlfZGVjb2RlZF9mbXRzW10gPSB7Cj4gKwl7Cj4gKwkJLmZvdXJj YyA9IFY0TDJfUElYX0ZNVF9OVjEyLAo+ICsJCS5pbWFnZV9mbXQgPSBSS1ZERUNfSU1HX0ZNVF80 MjBfOEJJVCwKPiArCX0sCj4gIH07Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IHJrdmRlY19j dHJsX2Rlc2Mgcmt2ZGVjX3ZwOV9jdHJsX2Rlc2NzW10gPSB7Cj4gQEAgLTI4Miw4ICszMDQsOSBA QCBzdGF0aWMgaW50IHJrdmRlY190cnlfY2FwdHVyZV9mbXQoc3RydWN0IGZpbGUgKmZpbGUsIHZv aWQgKnByaXYsCj4gIAlpZiAoV0FSTl9PTighY29kZWRfZGVzYykpCj4gIAkJcmV0dXJuIC1FSU5W QUw7Cj4gIAo+IC0JaWYgKCFya3ZkZWNfaXNfdmFsaWRfZm10KGN0eCwgcGl4X21wLT5waXhlbGZv cm1hdCkpCj4gLQkJcGl4X21wLT5waXhlbGZvcm1hdCA9IHJrdmRlY19lbnVtX2RlY29kZWRfZm10 KGN0eCwgMCk7Cj4gKwlpZiAoIXJrdmRlY19pc192YWxpZF9mbXQoY3R4LCBwaXhfbXAtPnBpeGVs Zm9ybWF0LCBjdHgtPmltYWdlX2ZtdCkpCj4gKwkJcGl4X21wLT5waXhlbGZvcm1hdCA9IHJrdmRl Y19lbnVtX2RlY29kZWRfZm10KGN0eCwgMCwKPiArCQkJCQkJCSAgICAgIGN0eC0+aW1hZ2VfZm10 KTsKPiAgCj4gIAkvKiBBbHdheXMgYXBwbHkgdGhlIGZybXNpemUgY29uc3RyYWludCBvZiB0aGUg Y29kZWQgZW5kLiAqLwo+ICAJcGl4X21wLT53aWR0aCA9IG1heChwaXhfbXAtPndpZHRoLCBjdHgt PmNvZGVkX2ZtdC5mbXQucGl4X21wLndpZHRoKTsKPiBAQCAtNDAwLDYgKzQyMyw3IEBAIHN0YXRp YyBpbnQgcmt2ZGVjX3Nfb3V0cHV0X2ZtdChzdHJ1Y3QgZmlsZSAqZmlsZSwgdm9pZCAqcHJpdiwK PiAgCSAqCj4gIAkgKiBOb3RlIHRoYXQgdGhpcyB3aWxsIHByb3BhZ2F0ZXMgYW55IHNpemUgY2hh bmdlcyB0byB0aGUgZGVjb2RlZCBmb3JtYXQuCj4gIAkgKi8KPiArCWN0eC0+aW1hZ2VfZm10ID0g UktWREVDX0lNR19GTVRfQU5ZOwo+ICAJcmt2ZGVjX3Jlc2V0X2RlY29kZWRfZm10KGN0eCk7Cj4g IAo+ICAJLyogUHJvcGFnYXRlIGNvbG9yc3BhY2UgaW5mb3JtYXRpb24gdG8gY2FwdHVyZS4gKi8K PiBAQCAtNDQ5LDcgKzQ3Myw3IEBAIHN0YXRpYyBpbnQgcmt2ZGVjX2VudW1fY2FwdHVyZV9mbXQo c3RydWN0IGZpbGUgKmZpbGUsIHZvaWQgKnByaXYsCj4gIAlzdHJ1Y3Qgcmt2ZGVjX2N0eCAqY3R4 ID0gZmhfdG9fcmt2ZGVjX2N0eChwcml2KTsKPiAgCXUzMiBmb3VyY2M7Cj4gIAo+IC0JZm91cmNj ID0gcmt2ZGVjX2VudW1fZGVjb2RlZF9mbXQoY3R4LCBmLT5pbmRleCk7Cj4gKwlmb3VyY2MgPSBy a3ZkZWNfZW51bV9kZWNvZGVkX2ZtdChjdHgsIGYtPmluZGV4LCBjdHgtPmltYWdlX2ZtdCk7Cj4g IAlpZiAoIWZvdXJjYykKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMvcmt2ZGVjLmggYi9kcml2ZXJzL3N0YWdpbmcvbWVk aWEvcmt2ZGVjL3JrdmRlYy5oCj4gaW5kZXggNjMzMzM1ZWJiOWM0Li42ZjhjZjUwYzVkOTkgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9zdGFnaW5nL21lZGlhL3JrdmRlYy9ya3ZkZWMuaAo+ICsrKyBi L2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMvcmt2ZGVjLmgKPiBAQCAtNzUsMTMgKzc1LDIz IEBAIHN0cnVjdCBya3ZkZWNfY29kZWRfZm10X29wcyB7Cj4gIAlpbnQgKCp0cnlfY3RybCkoc3Ry dWN0IHJrdmRlY19jdHggKmN0eCwgc3RydWN0IHY0bDJfY3RybCAqY3RybCk7Cj4gIH07Cj4gIAo+ ICtlbnVtIHJrdmRlY19pbWFnZV9mbXQgewo+ICsJUktWREVDX0lNR19GTVRfQU5ZID0gMCwKPiAr CVJLVkRFQ19JTUdfRk1UXzQyMF84QklULAo+ICt9Owo+ICsKPiArc3RydWN0IHJrdmRlY19kZWNv ZGVkX2ZtdF9kZXNjIHsKPiArCXUzMiBmb3VyY2M7Cj4gKwllbnVtIHJrdmRlY19pbWFnZV9mbXQg aW1hZ2VfZm10Owo+ICt9Owo+ICsKPiAgc3RydWN0IHJrdmRlY19jb2RlZF9mbXRfZGVzYyB7Cj4g IAl1MzIgZm91cmNjOwo+ICAJc3RydWN0IHY0bDJfZnJtc2l6ZV9zdGVwd2lzZSBmcm1zaXplOwo+ ICAJY29uc3Qgc3RydWN0IHJrdmRlY19jdHJscyAqY3RybHM7Cj4gIAljb25zdCBzdHJ1Y3Qgcmt2 ZGVjX2NvZGVkX2ZtdF9vcHMgKm9wczsKPiAgCXVuc2lnbmVkIGludCBudW1fZGVjb2RlZF9mbXRz Owo+IC0JY29uc3QgdTMyICpkZWNvZGVkX2ZtdHM7Cj4gKwljb25zdCBzdHJ1Y3Qgcmt2ZGVjX2Rl Y29kZWRfZm10X2Rlc2MgKmRlY29kZWRfZm10czsKPiAgCXUzMiBzdWJzeXN0ZW1fZmxhZ3M7Cj4g IH07Cj4gIAo+IEBAIC0xMDQsNiArMTE0LDcgQEAgc3RydWN0IHJrdmRlY19jdHggewo+ICAJY29u c3Qgc3RydWN0IHJrdmRlY19jb2RlZF9mbXRfZGVzYyAqY29kZWRfZm10X2Rlc2M7Cj4gIAlzdHJ1 Y3QgdjRsMl9jdHJsX2hhbmRsZXIgY3RybF9oZGw7Cj4gIAlzdHJ1Y3Qgcmt2ZGVjX2RldiAqZGV2 Owo+ICsJZW51bSBya3ZkZWNfaW1hZ2VfZm10IGltYWdlX2ZtdDsKPiAgCXZvaWQgKnByaXY7Cj4g IH07Cj4gIAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt cm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B8720C300 for ; Fri, 25 Oct 2024 17:36:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729877794; cv=none; b=qWzIsSp0Tvyf0yOKadinxFYWKhThrBKFYVfWNnwT3564BTbI0+3V0PcOdBigJ6KojK36yQhWaYpEJCQhcfQpf5co9xIb/Pigs0VEF4EXvVF1OE2wVPqpx01lQfgfcbco5ybErA3pANqIRFu2P8Y85VBGWQ57arnn3AObqvMUYk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729877794; c=relaxed/simple; bh=x4jpxHklaZinyrxH+w/otUFIrF7xpzlfk3/g5e1I3KE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qFe5QMjY7oEb1ZjUzULDI9g4E7EXY9hxQsb6eGS7lcdLUbSxSbr5uOGieaEdtFQzTVG9OW/gT4Yhskw5rHkOw73tHabW2jCBOQ2CPKu+Zc/BiGjRZCVs1qMUXPUIVnrApftl85HMJmHwKqV8wX1iX02bJgIbo39nx4rp9belW0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=RhWrmVOG; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="RhWrmVOG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1729877789; bh=x4jpxHklaZinyrxH+w/otUFIrF7xpzlfk3/g5e1I3KE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=RhWrmVOGzNQoNyvObXXer83FMP3ggDqn1HjeCx6WApTvtxLFVPvhMvbyP/Vdn+fQV SqTu2IzyAQB/jetcHZ0JArXoZmd4xdpSi96B53TpGq86qx3jOWqtmQAtasSvO2qxuQ 0Jmry+kTcmHcVh2NRAIkcDDIbu3cvh39CvB2+xEHfOYO6s9AYdz8El+cXYrrCn7kZz OWl5mfnYC+leB2tT3K+/RVCTb/xEZJuaz9+9ahafQ6UNAzNIdHNXotwSK8OdwLtxt+ qMwEugKqS/vlQmP9qOfx9C3zvcXcG8zdMtwr+qUYenBG+OrAToDRRNVyZ0bfh/ZGsk Pc65nNhGOGT5Q== Received: from nicolas-tpx395.lan (unknown [IPv6:2606:6d00:15:862e::7a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2450517E36AE; Fri, 25 Oct 2024 19:36:28 +0200 (CEST) Message-ID: <59ffa319a35e9e914bb5c8169df782ddabbd68c3.camel@collabora.com> Subject: Re: [PATCH v6 08/11] media: rkvdec: Add image format concept From: Nicolas Dufresne To: Jonas Karlman , Sebastian Fricke , Ezequiel Garcia , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Alex Bee , Benjamin Gaignard , Detlev Casanova , Dan Carpenter , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Christopher Obbard Date: Fri, 25 Oct 2024 13:36:27 -0400 In-Reply-To: <20240909192522.1076704-9-jonas@kwiboo.se> References: <20240909192522.1076704-1-jonas@kwiboo.se> <20240909192522.1076704-9-jonas@kwiboo.se> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Le lundi 09 septembre 2024 à 19:25 +0000, Jonas Karlman a écrit : > Add an enum rkvdec_image_fmt used to signal an image format, e.g. > 4:2:0 8-bit, 4:2:0 10-bit or any. > > Tag each supported CAPUTRE format with an image format and use this tag > to filter out unsupported CAPTURE formats. > > Signed-off-by: Jonas Karlman > Tested-by: Nicolas Dufresne > Tested-by: Christopher Obbard > --- > v6: > - Change to use fmt_idx instead of j++ tucked inside a condition (Dan) > > v5: > - Collect t-b tags > > v4: > - Change fmt_opaque into an image format > - Split patch into two > > v3: > - New patch > --- > drivers/staging/media/rkvdec/rkvdec.c | 48 ++++++++++++++++++++------- > drivers/staging/media/rkvdec/rkvdec.h | 13 +++++++- > 2 files changed, 48 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c > index efbf9aa578ae..467fc05b347a 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.c > +++ b/drivers/staging/media/rkvdec/rkvdec.c > @@ -27,26 +27,45 @@ > #include "rkvdec.h" > #include "rkvdec-regs.h" > > -static u32 rkvdec_enum_decoded_fmt(struct rkvdec_ctx *ctx, int index) > +static inline bool rkvdec_image_fmt_match(enum rkvdec_image_fmt fmt1, > + enum rkvdec_image_fmt fmt2) nit: We usually let the compiler inline function, specially when small and static. Reviewed-by: Nicolas Dufresne > +{ > + return fmt1 == fmt2 || fmt2 == RKVDEC_IMG_FMT_ANY || > + fmt1 == RKVDEC_IMG_FMT_ANY; > +} > + > +static u32 rkvdec_enum_decoded_fmt(struct rkvdec_ctx *ctx, int index, > + enum rkvdec_image_fmt image_fmt) > { > const struct rkvdec_coded_fmt_desc *desc = ctx->coded_fmt_desc; > + int fmt_idx = -1; > + unsigned int i; > > if (WARN_ON(!desc)) > return 0; > > - if (index >= desc->num_decoded_fmts) > - return 0; > + for (i = 0; i < desc->num_decoded_fmts; i++) { > + if (!rkvdec_image_fmt_match(desc->decoded_fmts[i].image_fmt, > + image_fmt)) > + continue; > + fmt_idx++; > + if (index == fmt_idx) > + return desc->decoded_fmts[i].fourcc; > + } > > - return desc->decoded_fmts[index]; > + return 0; > } > > -static bool rkvdec_is_valid_fmt(struct rkvdec_ctx *ctx, u32 fourcc) > +static bool rkvdec_is_valid_fmt(struct rkvdec_ctx *ctx, u32 fourcc, > + enum rkvdec_image_fmt image_fmt) > { > const struct rkvdec_coded_fmt_desc *desc = ctx->coded_fmt_desc; > unsigned int i; > > for (i = 0; i < desc->num_decoded_fmts; i++) { > - if (desc->decoded_fmts[i] == fourcc) > + if (rkvdec_image_fmt_match(desc->decoded_fmts[i].image_fmt, > + image_fmt) && > + desc->decoded_fmts[i].fourcc == fourcc) > return true; > } > > @@ -80,7 +99,7 @@ static void rkvdec_reset_decoded_fmt(struct rkvdec_ctx *ctx) > struct v4l2_format *f = &ctx->decoded_fmt; > u32 fourcc; > > - fourcc = rkvdec_enum_decoded_fmt(ctx, 0); > + fourcc = rkvdec_enum_decoded_fmt(ctx, 0, ctx->image_fmt); > rkvdec_reset_fmt(ctx, f, fourcc); > f->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; > f->fmt.pix_mp.width = ctx->coded_fmt.fmt.pix_mp.width; > @@ -149,8 +168,11 @@ static const struct rkvdec_ctrls rkvdec_h264_ctrls = { > .num_ctrls = ARRAY_SIZE(rkvdec_h264_ctrl_descs), > }; > > -static const u32 rkvdec_h264_vp9_decoded_fmts[] = { > - V4L2_PIX_FMT_NV12, > +static const struct rkvdec_decoded_fmt_desc rkvdec_h264_vp9_decoded_fmts[] = { > + { > + .fourcc = V4L2_PIX_FMT_NV12, > + .image_fmt = RKVDEC_IMG_FMT_420_8BIT, > + }, > }; > > static const struct rkvdec_ctrl_desc rkvdec_vp9_ctrl_descs[] = { > @@ -282,8 +304,9 @@ static int rkvdec_try_capture_fmt(struct file *file, void *priv, > if (WARN_ON(!coded_desc)) > return -EINVAL; > > - if (!rkvdec_is_valid_fmt(ctx, pix_mp->pixelformat)) > - pix_mp->pixelformat = rkvdec_enum_decoded_fmt(ctx, 0); > + if (!rkvdec_is_valid_fmt(ctx, pix_mp->pixelformat, ctx->image_fmt)) > + pix_mp->pixelformat = rkvdec_enum_decoded_fmt(ctx, 0, > + ctx->image_fmt); > > /* Always apply the frmsize constraint of the coded end. */ > pix_mp->width = max(pix_mp->width, ctx->coded_fmt.fmt.pix_mp.width); > @@ -400,6 +423,7 @@ static int rkvdec_s_output_fmt(struct file *file, void *priv, > * > * Note that this will propagates any size changes to the decoded format. > */ > + ctx->image_fmt = RKVDEC_IMG_FMT_ANY; > rkvdec_reset_decoded_fmt(ctx); > > /* Propagate colorspace information to capture. */ > @@ -449,7 +473,7 @@ static int rkvdec_enum_capture_fmt(struct file *file, void *priv, > struct rkvdec_ctx *ctx = fh_to_rkvdec_ctx(priv); > u32 fourcc; > > - fourcc = rkvdec_enum_decoded_fmt(ctx, f->index); > + fourcc = rkvdec_enum_decoded_fmt(ctx, f->index, ctx->image_fmt); > if (!fourcc) > return -EINVAL; > > diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h > index 633335ebb9c4..6f8cf50c5d99 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.h > +++ b/drivers/staging/media/rkvdec/rkvdec.h > @@ -75,13 +75,23 @@ struct rkvdec_coded_fmt_ops { > int (*try_ctrl)(struct rkvdec_ctx *ctx, struct v4l2_ctrl *ctrl); > }; > > +enum rkvdec_image_fmt { > + RKVDEC_IMG_FMT_ANY = 0, > + RKVDEC_IMG_FMT_420_8BIT, > +}; > + > +struct rkvdec_decoded_fmt_desc { > + u32 fourcc; > + enum rkvdec_image_fmt image_fmt; > +}; > + > struct rkvdec_coded_fmt_desc { > u32 fourcc; > struct v4l2_frmsize_stepwise frmsize; > const struct rkvdec_ctrls *ctrls; > const struct rkvdec_coded_fmt_ops *ops; > unsigned int num_decoded_fmts; > - const u32 *decoded_fmts; > + const struct rkvdec_decoded_fmt_desc *decoded_fmts; > u32 subsystem_flags; > }; > > @@ -104,6 +114,7 @@ struct rkvdec_ctx { > const struct rkvdec_coded_fmt_desc *coded_fmt_desc; > struct v4l2_ctrl_handler ctrl_hdl; > struct rkvdec_dev *dev; > + enum rkvdec_image_fmt image_fmt; > void *priv; > }; >