From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Date: Thu, 09 Nov 2017 09:16:02 +0000 Subject: Re: [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_pat Message-Id: <5A041CD2.7090600@samsung.com> List-Id: References: <4fbe6f7c-3ff4-6dbd-2980-8010dcc9548e@users.sourceforge.net> In-Reply-To: <4fbe6f7c-3ff4-6dbd-2980-8010dcc9548e@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: SF Markus Elfring , kernel-janitors@vger.kernel.org, Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , MyungJoo Ham Cc: LKML Hi, On 2017년 11월 09일 17:49, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 9 Nov 2017 09:40:59 +0100 > > The variable "ret" will be set to an appropriate value a bit later. > Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring > --- > drivers/extcon/extcon-max77693.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c > index 643411066ad9..227651ff9666 100644 > --- a/drivers/extcon/extcon-max77693.c > +++ b/drivers/extcon/extcon-max77693.c > @@ -266,7 +266,7 @@ static int max77693_muic_set_debounce_time(struct max77693_muic_info *info, > static int max77693_muic_set_path(struct max77693_muic_info *info, > u8 val, bool attached) > { > - int ret = 0; > + int ret; > unsigned int ctrl1, ctrl2 = 0; > > if (attached) > Applied it. But, it will be merged to v4.16-rc1. -- Best Regards, Chanwoo Choi Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754039AbdKIJQN (ORCPT ); Thu, 9 Nov 2017 04:16:13 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:11184 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753787AbdKIJQE (ORCPT ); Thu, 9 Nov 2017 04:16:04 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20171109091602epoutp04353970b77cbd672b117d26649ee84c52~1YCT-ixY10287302873epoutp04L X-AuditID: b6c32a48-8edff7000000103e-7f-5a041cd13bda MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <5A041CD2.7090600@samsung.com> Date: Thu, 09 Nov 2017 18:16:02 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: SF Markus Elfring , kernel-janitors@vger.kernel.org, Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , MyungJoo Ham Cc: LKML Subject: Re: [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_path() In-reply-to: <4fbe6f7c-3ff4-6dbd-2980-8010dcc9548e@users.sourceforge.net> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEKsWRmVeSWpSXmKPExsWy7bCmhe5FGZYog+/dXBYbZ6xntTjfuZzZ YustaYvz5zewW1zeNYfN4nbjCjYHNo9NqzrZPPq2rGL0aDrVzurxeZNcAEtUqk1GamJKapFC al5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0G4lhbLEnFKgUEBicbGS vp1NUX5pSapCRn5xia1StKGhkZ6hgbmekZGRnolxrJWRKVBJQmrG/F8TWQoOcFRsnP6TqYHx O1sXIyeHhICJxI8n+5i6GLk4hAR2MErsPnqcBcL5zijRN3UFUBUHWNXdm84Q8Q2MEmu+zwDr 5hUQlPgx+R4LSA2zgLzEkUvZIGFmAU2JF18mQc25xyixq+E2C0S9lsS1/8/BelkEVCUu9DSD 2WxA8f0vboDZ/AKKEld/PGYEsUUFIiR2zv/GDjJIROARo8SqxdeYIDaoS2zbd4UVxBYWKJL4 t2AHWDOngKfE+hn3mUEaJAR2sEmsP9rLBPGni8Tky1tYIWxhiVfHt7BD2NISz1ZtZIRoaGeU 2DznHguE08EocX9lI1SHscSprkao1XwSHYf/skPChVeio00IosRDYnJXF9QyR4ltx85A/T+H UeJw1zfWCYxys5CCbBYiyGYhBdkCRuZVjGKpBcW56anFRgUmesWJucWleel6yfm5mxjB6U3L YwfjgXM+hxgFOBiVeHhfrGKOEmJNLCuuzD3EKMHBrCTCK/IWKMSbklhZlVqUH19UmpNafIjR FBjiE5mlRJPzgak3ryTe0MTSwMTMzMjczAKYxMR567ZdixASSE8sSc1OTS1ILYLpY+LglGpg 3D63+de1+uQ/la/qvslP/Xkk7EH/2WtaSZrTel9ecDZ1cfjypn/yCe85gUUuu5pa35XP4PGS qPE1OzLjd8XEu1c/bFm/eXmyuLiFz62/y3Y1TD/ZMu/jgpiYQ+c3LD0mGGvztmzvXUuZSNVP XsyqM5e8unFE1q32xcmoQ2tm7WVk0lT5rmicFK/EUpyRaKjFXFScCAB8ESCShQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t9jQd0LMixRBu+azCw2zljPanG+czmz xdZb0hbnz29gt7i8aw6bxe3GFWwObB6bVnWyefRtWcXo0XSqndXj8ya5AJYoLpuU1JzMstQi fbsEroz5vyayFBzgqNg4/SdTA+N3ti5GDg4JAROJuzeduxi5OIQE1jFK3Hj1hbmLkZODV0BQ 4sfkeywgNcwC8hJHLmVDmOoSU6bkQpQ/YJR4svgUK0S5lsS1/8/ZQGwWAVWJCz3NYDYbUHz/ ixtgNr+AosTVH48ZQeaICkRIdJ+oBJkjIvCIUWLVpB5GkBqQ+dv2XQGbKSxQJPFvwQ6wXiGB eYwSS//ogdicAp4S62fcZ57AKDALyaWzEC6dhXDpAkbmVYySqQXFuem5xUYFRnmp5XrFibnF pXnpesn5uZsYgeG87bBW/w7Gx0viDzEKcDAq8fA6rGWOEmJNLCuuzD3EKMHBrCTCK/IWKMSb klhZlVqUH19UmpNafIhRmoNFSZyXP/9YpJBAemJJanZqakFqEUyWiYNTqoGxfksP58PEU8Xv v03akNH5uzRqffgjM64w1jlWkfdvnJQ5ZOW60lfi8KQHy2aFqrKL7H5r8cD0lJbm+yeeWXaX FK/5yD+bs2nKR+5lzAFuXTUswUZf+C4xbgsVb7969sBL3017t55UCLU6wvu7q9Rr/pyb3I+O 2c/V8+UQSlodskD/ncD62gp1JZbijERDLeai4kQA8bal02MCAAA= X-CMS-MailID: 20171109091600epcas2p1d9a3dd4e8398afcbb35daaa92ecbcdc7 X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171109084920epcas2p1a711136b29d823b7ce7d4bc56be69bb9 X-RootMTR: 20171109084920epcas2p1a711136b29d823b7ce7d4bc56be69bb9 References: <4fbe6f7c-3ff4-6dbd-2980-8010dcc9548e@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 11월 09일 17:49, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 9 Nov 2017 09:40:59 +0100 > > The variable "ret" will be set to an appropriate value a bit later. > Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring > --- > drivers/extcon/extcon-max77693.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c > index 643411066ad9..227651ff9666 100644 > --- a/drivers/extcon/extcon-max77693.c > +++ b/drivers/extcon/extcon-max77693.c > @@ -266,7 +266,7 @@ static int max77693_muic_set_debounce_time(struct max77693_muic_info *info, > static int max77693_muic_set_path(struct max77693_muic_info *info, > u8 val, bool attached) > { > - int ret = 0; > + int ret; > unsigned int ctrl1, ctrl2 = 0; > > if (attached) > Applied it. But, it will be merged to v4.16-rc1. -- Best Regards, Chanwoo Choi Samsung Electronics