From mboxrd@z Thu Jan 1 00:00:00 1970 From: arvindY Subject: Re: [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking Date: Mon, 20 Nov 2017 21:54:42 +0530 Message-ID: <5A1301CA.7070407@gmail.com> References: <20171118183029.zooxomhrejzatuvd@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:39936 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbdKTQYs (ORCPT ); Mon, 20 Nov 2017 11:24:48 -0500 In-Reply-To: <20171118183029.zooxomhrejzatuvd@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: maxime.ripard@free-electrons.com, wens@csie.org, mcuos.com@gmail.com, linux@roeck-us.net, linux@armlinux.org.uk, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Dmitry, On Sunday 19 November 2017 12:00 AM, Dmitry Torokhov wrote: > On Sat, Nov 18, 2017 at 04:25:08PM +0530, Arvind Yadav wrote: >> The platform_get_irq() function returns negative if an error occurs. >> zero or positive number on success. platform_get_irq() error checking >> for zero is not correct. >> >> Signed-off-by: Arvind Yadav >> --- >> changes in v2: >> Return keypad->irq insted of -ENXIO. >> changes in v3 : >> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. >> >> drivers/input/keyboard/ep93xx_keypad.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c >> index f77b295..01788a7 100644 >> --- a/drivers/input/keyboard/ep93xx_keypad.c >> +++ b/drivers/input/keyboard/ep93xx_keypad.c >> @@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev) >> } >> >> keypad->irq = platform_get_irq(pdev, 0); >> - if (!keypad->irq) { >> - err = -ENXIO; >> + if (keypad->irq <= 0) { >> + err = keypad->irq; > Argh, so what will happen if you return with keypad->irq == 0? Can you > please stop and consider what exactly you are doing before churning > patches like crazy? Sorry for troubling you, I am sending updated patch of this( version - v4). If you are ok with v4. Then I will send other patch. Thanks, >> goto failed_free; >> } >> >> -- >> 2.7.4 >> > Thanks. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: arvind.yadav.cs@gmail.com (arvindY) Date: Mon, 20 Nov 2017 21:54:42 +0530 Subject: [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking In-Reply-To: <20171118183029.zooxomhrejzatuvd@dtor-ws> References: <20171118183029.zooxomhrejzatuvd@dtor-ws> Message-ID: <5A1301CA.7070407@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Dmitry, On Sunday 19 November 2017 12:00 AM, Dmitry Torokhov wrote: > On Sat, Nov 18, 2017 at 04:25:08PM +0530, Arvind Yadav wrote: >> The platform_get_irq() function returns negative if an error occurs. >> zero or positive number on success. platform_get_irq() error checking >> for zero is not correct. >> >> Signed-off-by: Arvind Yadav >> --- >> changes in v2: >> Return keypad->irq insted of -ENXIO. >> changes in v3 : >> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. >> >> drivers/input/keyboard/ep93xx_keypad.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c >> index f77b295..01788a7 100644 >> --- a/drivers/input/keyboard/ep93xx_keypad.c >> +++ b/drivers/input/keyboard/ep93xx_keypad.c >> @@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev) >> } >> >> keypad->irq = platform_get_irq(pdev, 0); >> - if (!keypad->irq) { >> - err = -ENXIO; >> + if (keypad->irq <= 0) { >> + err = keypad->irq; > Argh, so what will happen if you return with keypad->irq == 0? Can you > please stop and consider what exactly you are doing before churning > patches like crazy? Sorry for troubling you, I am sending updated patch of this( version - v4). If you are ok with v4. Then I will send other patch. Thanks, >> goto failed_free; >> } >> >> -- >> 2.7.4 >> > Thanks. >