From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format Date: Wed, 22 Nov 2017 14:13:54 +0900 Message-ID: <5A150792.6050104@samsung.com> References: <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:25151 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbdKVFNy (ORCPT ); Wed, 22 Nov 2017 00:13:54 -0500 In-reply-to: <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Joe Perches , MyungJoo Ham , Kyungmin Park Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On 2017년 11월 17일 00:27, Joe Perches wrote: > Line continuations with excess spacing causes unexpected output. > > Signed-off-by: Joe Perches > --- > drivers/devfreq/rk3399_dmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c > index 5dfbfa3cc878..0938c97d46f0 100644 > --- a/drivers/devfreq/rk3399_dmc.c > +++ b/drivers/devfreq/rk3399_dmc.c > @@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq, > > /* If get the incorrect rate, set voltage to old value. */ > if (dmcfreq->rate != target_rate) { > - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ > - Current frequency %lu\n", target_rate, dmcfreq->rate); > + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n", > + target_rate, dmcfreq->rate); IMO, I don't like over 80 char in the one line. > regulator_set_voltage(dmcfreq->vdd_center, dmcfreq->volt, > dmcfreq->volt); > goto out; > -- Best Regards, Chanwoo Choi Samsung Electronics