From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format Date: Thu, 23 Nov 2017 11:23:21 +0900 Message-ID: <5A163119.1050500@samsung.com> References: <1511347280.6989.81.camel@perches.com> <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> <5A150792.6050104@samsung.com> <20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee@epcms1p1> <5A162835.5050806@samsung.com> <1511402826.2385.3.camel@perches.com> <5A162E8A.3040207@samsung.com> <1511403518.2385.8.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:30997 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbdKWCXV (ORCPT ); Wed, 22 Nov 2017 21:23:21 -0500 In-reply-to: <1511403518.2385.8.camel@perches.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Joe Perches , myungjoo.ham@samsung.com, Kyungmin Park Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" On 2017년 11월 23일 11:18, Joe Perches wrote: > On Thu, 2017-11-23 at 11:12 +0900, Chanwoo Choi wrote: >> On 2017년 11월 23일 11:07, Joe Perches wrote: >>> On Thu, 2017-11-23 at 10:45 +0900, Chanwoo Choi wrote: >>>> On 2017년 11월 23일 10:21, MyungJoo Ham wrote: >>>>>> On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: >>>>>>> On 2017년 11월 17일 00:27, Joe Perches wrote: >>>>>>>> Line continuations with excess spacing causes unexpected output. >>>>>>>> >>>>>>>> Signed-off-by: Joe Perches >>>>>>>> --- >>>>>>>> drivers/devfreq/rk3399_dmc.c | 4 ++-- >>>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>>> >>>>>>>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >>>>>>>> index 5dfbfa3cc878..0938c97d46f0 100644 >>>>>>>> --- a/drivers/devfreq/rk3399_dmc.c >>>>>>>> +++ b/drivers/devfreq/rk3399_dmc.c >>>>>>>> @@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq, >>>>>>>> >>>>>>>> /* If get the incorrect rate, set voltage to old value. */ >>>>>>>> if (dmcfreq->rate != target_rate) { >>>>>>>> - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ >>>>>>>> - Current frequency %lu\n", target_rate, dmcfreq->rate); >>>>>>>> + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n", >>>>>>>> + target_rate, dmcfreq->rate); >>>>>>> >>>>>>> IMO, I don't like over 80 char in the one line. >>>>>> >>>>>> Fix it as you chose, but the code I proposed >>>>>> is what is preferred by CodingStyle. >>>>>> >>>>>> The current code is unintentional. >>>>>> >>>>>> Right now there are 3 tabs between "Request frequency" >>>>>> and "Current frequency" in the output. >>>>> >>>>> Chanwoo, this is not a simple coding style issue. >>>>> I'm seeing these unintentional tabs as well. >>>>> >>>>> >>>>> If you want to keep it 80 cols with strings (which is r mandatory for strings in double quotes), >>>>> We'd better do: >>>>> >>>>> - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ >>>>> - Current frequency %lu\n", target_rate, dmcfreq->rate); >>>>> + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu," >>>>> + " Current frequency %lu\n", target_rate, dmcfreq->rate); >>>> >>>> I agree with Myungjoo's opinion. >>>> I think the readability is important. So, I prefer to keep one line within 80 char. >>> >>> Read Documentation/process/coding-style.rst >>> >>> What I proposed is by far the common style. >>> I think you should get used to it. >> >> Read line.81 in the Documentation/process/coding-style.rst >> - "2) Breaking long lines and strings" >> >> Or, we better to modify the error message within 80 char. > > Exactly! > > line 94: > > never break user-visible strings such as > printk messages, because that breaks the ability to grep for them So, I suggested "Or, we better to modify the error message within 80 char.". -- Best Regards, Chanwoo Choi Samsung Electronics