From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH] dsa: dsa2: fix compile error for !CONFIG_OF Date: Fri, 24 Nov 2017 10:34:41 +0100 Message-ID: <5A17E7B1.8000609@broadcom.com> References: <5A16B873.1060709@broadcom.com> <20171123140459.GC30167@lunn.ch> <20171124022826.GA32569@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "open list:NETWORKING DRIVERS" , Vivien Didelot , Arnd Bergmann To: Andrew Lunn Return-path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:34362 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbdKXJen (ORCPT ); Fri, 24 Nov 2017 04:34:43 -0500 Received: by mail-qt0-f193.google.com with SMTP id 33so21836039qtv.1 for ; Fri, 24 Nov 2017 01:34:43 -0800 (PST) In-Reply-To: <20171124022826.GA32569@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: On 11/24/2017 3:28 AM, Andrew Lunn wrote: > On Thu, Nov 23, 2017 at 08:27:48PM +0100, Arend Van Spriel wrote: >> + Arnd >> >> On Thu, Nov 23, 2017 at 8:12 PM, Arend Van Spriel >> wrote: >>> On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn wrote: >>>> On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote: >>>>> Compilation fails building on x86_64 platform which does not >>>>> have CONFIG_OF enabled. >>>>> >>>>> Signed-off-by: Arend van Spriel >>>>> --- >>>>> After rebasing my branch to v4.14 I attempted to build the kernel and hit >>>>> the following compile issue: >>>>> >>>>> net/dsa/dsa2.c: In function \u2018dsa_switch_parse_member_of\u2019: >>>>> net/dsa/dsa2.c:678:2: error: implicit declaration of function >>>>> 'of_property_read_variable_u32_array' >>>> >>>> Hi Arend >>>> >>>> https://lkml.org/lkml/2017/11/6/493 >>> >>> So my email/patch did get through initially. Sorry for the noise and >>> thanks for the info. >> >> Hi Andrew, >> >> Getting back to this. It seems that this patch did not get in. At >> least I searched for it in v4.14.1 but no luck. > > Hi Arned > > The use of of_property_read_variable_u32_array was added in > 975e6e32215e ("net: dsa: rework switch parsing"). This patch is not in > v4.14. It is in linus/master, so v4.15-rc1 should have it. And the fix > is also in linus/master. > > So there does not appear to be anything wrong. I just built v4.14.1 > for x86_64 with DSA without problems. Thanks, Andrew I am actually using wireless-testing tree which it based on 4.14 and throws in net-next and the wireless trees. I assume the fix did not go through net-next. Sorry for the confusion. Regards, Arend