From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from foss.arm.com ([217.140.101.70]:36908 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751785AbdK0Lxg (ORCPT <rfc822;stable@vger.kernel.org>);
        Mon, 27 Nov 2017 06:53:36 -0500
Message-ID: <5A1BFC4B.2050205@arm.com>
Date: Mon, 27 Nov 2017 11:51:39 +0000
From: James Morse <james.morse@arm.com>
MIME-Version: 1.0
To: gregkh@linuxfoundation.org, rafael.j.wysocki@intel.com
CC: bp@suse.de, stable@vger.kernel.org, stable-commits@vger.kernel.org
Subject: Re: Patch "ACPI / APEI: Remove arch_apei_flush_tlb_one()" has been
 added to the 4.14-stable tree
References: <15116180256928@kroah.com>
In-Reply-To: <15116180256928@kroah.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Hi Greg,

On 25/11/17 13:53, gregkh@linuxfoundation.org wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     ACPI / APEI: Remove arch_apei_flush_tlb_one()
> 
> to the 4.14-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      acpi-apei-remove-arch_apei_flush_tlb_one.patch
> and it can be found in the queue-4.14 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.

I don't think this patch should applied to the stable trees:

This patch is cleanup following 'ACPI / APEI: Replace ioremap_page_range() with
fixmap', which failed to apply to this tree. Having this patch will lead to
build-breakage with exotic Kconfig options!


Thanks,

James

> From 4a75aeacda3c2455954596593d89187df5420d0a Mon Sep 17 00:00:00 2001
> From: James Morse <james.morse@arm.com>
> Date: Mon, 6 Nov 2017 18:44:27 +0000
> Subject: ACPI / APEI: Remove arch_apei_flush_tlb_one()
> 
> From: James Morse <james.morse@arm.com>
> 
> commit 4a75aeacda3c2455954596593d89187df5420d0a upstream.
> 
> Nothing calls arch_apei_flush_tlb_one() anymore, instead relying on
> __set_pte_vaddr() to do the invalidation when called from clear_fixmap()
> Remove arch_apei_flush_tlb_one().
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> Reviewed-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> ---
>  arch/x86/kernel/acpi/apei.c |    5 -----
>  include/acpi/apei.h         |    1 -
>  2 files changed, 6 deletions(-)
> 
> --- a/arch/x86/kernel/acpi/apei.c
> +++ b/arch/x86/kernel/acpi/apei.c
> @@ -52,8 +52,3 @@ void arch_apei_report_mem_error(int sev,
>  	apei_mce_report_mem_error(sev, mem_err);
>  #endif
>  }
> -
> -void arch_apei_flush_tlb_one(unsigned long addr)
> -{
> -	__flush_tlb_one(addr);
> -}
> --- a/include/acpi/apei.h
> +++ b/include/acpi/apei.h
> @@ -51,7 +51,6 @@ int erst_clear(u64 record_id);
>  
>  int arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data);
>  void arch_apei_report_mem_error(int sev, struct cper_sec_mem_err *mem_err);
> -void arch_apei_flush_tlb_one(unsigned long addr);
>  
>  #endif
>  #endif
> 
> 
> Patches currently in stable-queue which might be from james.morse@arm.com are
> 
> queue-4.14/acpi-apei-remove-arch_apei_flush_tlb_one.patch
>