From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wei Hu (Xavier)" Subject: Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver Date: Tue, 28 Nov 2017 14:28:04 +0800 Message-ID: <5A1D01F4.8000800@huawei.com> References: <1511750484-102395-1-git-send-email-xavier.huwei@huawei.com> <20171127183637.GA13966@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171127183637.GA13966-uk2M96/98Pc@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xavier.huwei-WVlzvzqoTvw@public.gmane.org, xavier_huwei-9Onoh4P/yGk@public.gmane.org, linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 2017/11/28 2:36, Jason Gunthorpe wrote: > On Mon, Nov 27, 2017 at 10:41:21AM +0800, Wei Hu (Xavier) wrote: >> This patch-set introduces three patches to fix about the memory >> related issues. > If these patches are for-rc can you revise the commit message to more > clearly explain what the bug is, and supply Fixes lines? Ok, I will modify the commit message and add Fixes lines. And I will send patch V2 for-rc. Thanks. > Otherwise these will go to 4.16 > > It looks like the first one is for-rc material as it looks like DMA > will fail sometimes if the smmu is enabled? Yes, The first one fixes the MTPT configuration error that probably cause dma operation failure. > The other two are less clear to me - is this just fixing the code to > conform to the DMA API, or is there an actual real user-impacting bug here? The other two patches fixes incorrect usage of dma API that may cause coherency problems. Regards Wei Hu > Thanks > Jason > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751693AbdK1G2P (ORCPT ); Tue, 28 Nov 2017 01:28:15 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2183 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751648AbdK1G2O (ORCPT ); Tue, 28 Nov 2017 01:28:14 -0500 Subject: Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver To: Jason Gunthorpe References: <1511750484-102395-1-git-send-email-xavier.huwei@huawei.com> <20171127183637.GA13966@ziepe.ca> CC: , , , , , From: "Wei Hu (Xavier)" Message-ID: <5A1D01F4.8000800@huawei.com> Date: Tue, 28 Nov 2017 14:28:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20171127183637.GA13966@ziepe.ca> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.115.182] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/11/28 2:36, Jason Gunthorpe wrote: > On Mon, Nov 27, 2017 at 10:41:21AM +0800, Wei Hu (Xavier) wrote: >> This patch-set introduces three patches to fix about the memory >> related issues. > If these patches are for-rc can you revise the commit message to more > clearly explain what the bug is, and supply Fixes lines? Ok, I will modify the commit message and add Fixes lines. And I will send patch V2 for-rc. Thanks. > Otherwise these will go to 4.16 > > It looks like the first one is for-rc material as it looks like DMA > will fail sometimes if the smmu is enabled? Yes, The first one fixes the MTPT configuration error that probably cause dma operation failure. > The other two are less clear to me - is this just fixing the code to > conform to the DMA API, or is there an actual real user-impacting bug here? The other two patches fixes incorrect usage of dma API that may cause coherency problems. Regards Wei Hu > Thanks > Jason > >